Repository navigation
[CALCITE-7909] ProjectSetOpTransposeRule returns wrong results for EXCEPT ALL and INTERSECT ALL - #5378
Open
snuyanzin wants to merge 2 commits into
Open
[CALCITE-7909] ProjectSetOpTransposeRule returns wrong results for EXCEPT ALL and INTERSECT ALL#5378snuyanzin wants to merge 2 commits into
ProjectSetOpTransposeRule returns wrong results for EXCEPT ALL and INTERSECT ALL#5378snuyanzin wants to merge 2 commits into
Conversation
…`EXCEPT ALL` and `INTERSECT ALL`
mihaibudiu
reviewed
Oct 30, 2026
|
|
||
| // cannot push project past a distinct | ||
| if (!setOp.all) { | ||
| // only UNION ALL; other set ops compare rows on all fields |
mihaibudiu
approved these changes
Oct 30, 2026
mihaibudiu
left a comment
mihaibudiu
left a comment
Contributor
There was a problem hiding this comment.
This is fine, but perhaps the rule should not be called SetOp anymore
snuyanzin
force-pushed
the
calcite7909
branch
from
October 30, 2026 23:47
9eacdfb to
342e146
Compare
|
manish1337
added a commit
to manish1337/flink
that referenced
this pull request
Nov 1, 2026
…link rule Copy Calcite's ProjectSetOpTransposeRule with the fix of CALCITE-7909 (apache/calcite#5378) and drop FlinkProjectSetOpTransposeRule, so both rule sets use CoreRules.PROJECT_SET_OP_TRANSPOSE again. The copy should be removed after upgrading to a Calcite version that contains the fix. The plans are the same as with FlinkProjectSetOpTransposeRule. The fix is in a logical rule that batch and streaming share, so keep only the streaming semantic tests. Generated-by: Claude Code (Claude Opus 5.5)
mihaibudiu
added
the
LGTM-will-merge-soon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Link
CALCITE-7909
Changes Proposed
The PR fixes behavior of ProjectSetOpTransposeRule for the case of
EXCEPT ALL,INTERSECT ALL