Skip to content

fix(android): correct EXIF orientation for non-JPEG camera captures #976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GitToTheHub wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(android): correct EXIF orientation for non-JPEG camera captures #976

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/android/CameraLauncher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,7 +526,11 @@ private void processResultFromCamera(int destType, Intent intent) throws IOExcep
}
else {
input = cordova.getActivity().getContentResolver().openInputStream(imageUri);
mimeType = FileHelper.getMimeType(imageUri.toString(), cordova);
// MediaStore.ACTION_IMAGE_CAPTURE always writes JPEG data into imageUri, regardless of
// its file extension (which reflects the requested encodingType, not the actual format).
// Relying on FileHelper.getMimeType(imageUri) here would misreport PNG-named captures as
// image/png, causing getScaledAndRotatedBitmap() to skip reading the EXIF orientation.
mimeType = JPEG_MIME_TYPE;
}

if (input == null) {
Expand Down
Loading