Repository navigation
feat: PHP SDK update for version 31.0.0 - #95
Conversation
馃數 Tier A 路 Mergeable after minor fixes
Updates the PHP SDK to target Appwrite 2.5 response shapes and adds support for the new query, restoration, SMTP-rule, and email-trigger APIs. It also adds optional PSR-18 transport injection and updates the corresponding models, tests, and documentation. 167 of 290 changed files were too large to include in full.
Note Part of the diff was too large to review, so Hansi did not approve.
Fix with agent prompt### Issue 1
src/Appwrite/Models/OAuth2Kakao.php:59
**Add coverage for a scalar OAuth2 prompt response**
This new branch handles a scalar `prompt`, but the existing OAuth2 fixtures still provide prompt values as lists. A scalar-response regression would therefore go unnoticed; please add a fixture that verifies it hydrates to a one-item prompt list.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.馃搨 Walkthrough 路 6
Reviewed |
|
@hansi-codes review |
|
@hansi-codes review |
| $data['prompt'] | ||
| ) | ||
| : $data['prompt'] | ||
| : [static::hydrateTypedValue(OAuth2KakaoPrompt::class, $data['prompt'])] |
There was a problem hiding this comment.
Add coverage for a scalar OAuth2 prompt response
This new branch handles a scalar prompt, but the existing OAuth2 fixtures still provide prompt values as lists. A scalar-response regression would therefore go unnoticed; please add a fixture that verifies it hydrates to a one-item prompt list.
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/Appwrite/Models/OAuth2Kakao.php
Line: 59
Comment:
**Add coverage for a scalar OAuth2 prompt response**
This new branch handles a scalar `prompt`, but the existing OAuth2 fixtures still provide prompt values as lists. A scalar-response regression would therefore go unnoticed; please add a fixture that verifies it hydrates to a one-item prompt list.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.馃煛 Minor 路 testing 路 Reply if this doesn't apply.
This PR contains updates to the SDK for version 31.0.0.
What's Changed
X-Appwrite-Response-Format: 2.5.0; responses follow the 2.5 shapesAccount::listLogs,Users::listLogsand theLog/LogListmodelsOrganization::createKey,getKey,listKeys,updateKeyanddeleteKey, andOrganizationKeyScopes; useOrganization::listProjectKeys,getProjectKey,updateProjectKeyanddeleteProjectKeyinsteadClient::setDevKey, theDevKeymodel andProject::$devKeysBillingPlanGroup::STARTER(); useBillingPlanGroup::FREE()listSpecificationsreturns each specification's prices and overage rates on the row itself. Removed the list-level$pricingfield and theDedicatedDatabaseSpecificationPricingmodelBlockfieldsreason,projectName,region,organizationName,organizationIdandbillingPlanresourceparams now take?arrayProject::updateOAuth2Kakaotakes$enabledbefore$promptBackupRestoration::$optionsis now an arrayBillingPlan::$usageandDedicatedDatabase::$engineClient::flattenis renamedflattenForm; subclasses that override it must rename itTopichelper to build MQTT topics for push messagesMongo,MysqlandPostgresqlpromoteRestoration,$restoreMode,$targetNameand$autoPromoteoncreateRestoration, andDedicatedDatabaseRestoration::$restoreModeProxy::createSMTPRule, theProxyRuleProtocolenum andProxyRule::$protocol$emailEnabledonFunctions::updateandFunctionModel, andExecutionTrigger::EMAIL()Queryaggregates (count,countDistinct,sum,avg,min,maxand more),groupBy,having,distinct, joins,relationship,covers,spatialEqualsandpageQuery::builder()to chain queries;build()returns the query listpromptvalue in a list