Skip to content

Clean scheduled benchmark job work directories #2214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LoopedBard3 merged 3 commits into from
Oct 8, 2026
Merged

Clean scheduled benchmark job work directories #2214

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d3c69d
Use keyed reuse for scheduled Docker jobs
LoopedBard3 Oct 6, 2026
5a38859
Address container reuse review feedback
LoopedBard3 Oct 6, 2026
9494cfc
Narrow scheduled cleanup to noClean removal
LoopedBard3 Oct 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/frameworks-database-scenarios.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,5 +108,5 @@ steps:
"name": "crank",
"condition": "(${{ parameters.condition }})",
"retries": 1,
"args": [ "${{ s.arguments }} ${{ parameters.arguments }} ${{ parameters.config }} --application.noClean true --no-metadata --no-measurements --load.options.reuseBuild true --session $(session) --description \"${{ s.displayName }} $(System.JobDisplayName)\" --property buildId=\"$(buildId)\" --property buildNumber=\"$(buildNumber)\" --command-line-property --table TrendBenchmarks --sql SQL_CONNECTION_STRING --cert-tenant-id SQL_SERVER_TENANTID --cert-client-id SQL_SERVER_CLIENTID --cert-path SQL_SERVER_CERT_PATH --cert-sni --chart" ]
"args": [ "${{ s.arguments }} ${{ parameters.arguments }} ${{ parameters.config }} --no-metadata --no-measurements --load.options.reuseBuild true --session $(session) --description \"${{ s.displayName }} $(System.JobDisplayName)\" --property buildId=\"$(buildId)\" --property buildNumber=\"$(buildNumber)\" --command-line-property --table TrendBenchmarks --sql SQL_CONNECTION_STRING --cert-tenant-id SQL_SERVER_TENANTID --cert-client-id SQL_SERVER_CLIENTID --cert-path SQL_SERVER_CERT_PATH --cert-sni --chart" ]
}
2 changes: 1 addition & 1 deletion build/frameworks-scenarios.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,5 +98,5 @@ steps:
"name": "crank",
"condition": "(${{ parameters.condition }})",
"retries": 1,
"args": [ "${{ s.arguments }} ${{ parameters.arguments }} ${{ parameters.config }} --application.noClean true --no-metadata --no-measurements --load.options.reuseBuild true --session $(session) --description \"${{ s.displayName }} $(System.JobDisplayName)\" --property buildId=\"$(buildId)\" --property buildNumber=\"$(buildNumber)\" --command-line-property --table TrendBenchmarks --sql SQL_CONNECTION_STRING --cert-tenant-id SQL_SERVER_TENANTID --cert-client-id SQL_SERVER_CLIENTID --cert-path SQL_SERVER_CERT_PATH --cert-sni --chart" ]
"args": [ "${{ s.arguments }} ${{ parameters.arguments }} ${{ parameters.config }} --no-metadata --no-measurements --load.options.reuseBuild true --session $(session) --description \"${{ s.displayName }} $(System.JobDisplayName)\" --property buildId=\"$(buildId)\" --property buildNumber=\"$(buildNumber)\" --command-line-property --table TrendBenchmarks --sql SQL_CONNECTION_STRING --cert-tenant-id SQL_SERVER_TENANTID --cert-client-id SQL_SERVER_CLIENTID --cert-path SQL_SERVER_CERT_PATH --cert-sni --chart" ]
}
3 changes: 2 additions & 1 deletion scenarios/containers.benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ jobs:
environmentVariables:
database: "PostgreSQL"
connectionString: '"Server={{databaseServer}};Database=hello_world;User Id=benchmarkdbuser;Password=benchmarkdbpass;Maximum Pool Size=256;NoResetOnClose=true;Enlist=false;Max Auto Prepare=4"'
noClean: true
options:
reuseBuild: true
Comment thread
LoopedBard3 marked this conversation as resolved.
Outdated

scenarios:
json_aspnet:
Expand Down
6 changes: 4 additions & 2 deletions scenarios/database.benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ jobs:
dockerImageName: postgres_te
dockerContextDirectory: toolset/databases/postgres
readyStateText: ready to accept connections
noClean: true
options:
reuseBuild: true

mssql:
source:
Expand All @@ -43,7 +44,8 @@ jobs:
dockerImageName: mssql_te
dockerContextDirectory: docker/mssql-techempower
readyStateText: Data imported
noClean: true
options:
reuseBuild: true

scenarios:
fortunes:
Expand Down
3 changes: 2 additions & 1 deletion scenarios/goldilocks.benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ jobs:
dockerImageName: postgres_te
dockerContextDirectory: toolset/databases/postgres
readyStateText: ready to accept connections
noClean: true
options:
reuseBuild: true


scenarios:
Expand Down
3 changes: 2 additions & 1 deletion scenarios/orchard.benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@ jobs:
dockerImageName: postgres_te
dockerContextDirectory: toolset/databases/postgres
readyStateText: ready to accept connections
noClean: true
options:
reuseBuild: true

scenarios:
about-sqlite:
Expand Down
3 changes: 2 additions & 1 deletion scenarios/platform.benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ jobs:
dockerImageName: postgres_te
dockerContextDirectory: toolset/databases/postgres
readyStateText: ready to accept connections
noClean: true
options:
reuseBuild: true

scenarios:
plaintext:
Expand Down
44 changes: 29 additions & 15 deletions scenarios/te.benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ jobs:
dockerContextDirectory: frameworks/CSharp/aspnetcore/
readyStateText: Application started
arguments: --add-host="tfb-database:{{databaseServer}}"
noClean: true
options:
reuseBuild: true

nodejs:
source:
Expand All @@ -25,7 +26,8 @@ jobs:
dockerContextDirectory: frameworks/JavaScript/nodejs/
readyStateText: NodeJS worker listening
arguments: --add-host="tfb-database:{{databaseServer}}"
noClean: true
options:
reuseBuild: true

bun:
source:
Expand All @@ -36,7 +38,8 @@ jobs:
dockerContextDirectory: frameworks/TypeScript/bun/
readyStateText: Listening
# arguments: --add-host="tfb-database:{{databaseServer}}"
noClean: true
options:
reuseBuild: true

express:
source:
Expand All @@ -47,7 +50,8 @@ jobs:
dockerContextDirectory: frameworks/JavaScript/express/
readyStateText: is running
arguments: --add-host="tfb-database:{{databaseServer}}"
noClean: true
options:
reuseBuild: true

express_postgresql:
source:
Expand All @@ -58,7 +62,8 @@ jobs:
dockerContextDirectory: frameworks/JavaScript/express/
readyStateText: listening
arguments: --add-host="tfb-database:{{databaseServer}}"
noClean: true
options:
reuseBuild: true

gin:
source:
Expand All @@ -70,7 +75,8 @@ jobs:
readyStateText: Listening
port: 8080 # used to poll the application to detect startup
arguments: --add-host="tfb-database:{{databaseServer}}"
noClean: true
options:
reuseBuild: true

ntex: # json and plaintext scenarios
source:
Expand All @@ -81,7 +87,8 @@ jobs:
dockerContextDirectory: frameworks/Rust/ntex/
readyStateText: Started http server
arguments: --add-host="tfb-database:{{databaseServer}}"
noClean: true
options:
reuseBuild: true

xitca:
source:
Expand All @@ -93,7 +100,8 @@ jobs:
# readyStateText: Starting http server
port: 8080 # used to poll the application to detect startup
arguments: --add-host="tfb-database:{{databaseServer}}"
noClean: true
options:
reuseBuild: true

fasthttp:
source:
Expand All @@ -105,7 +113,8 @@ jobs:
arguments: --add-host="tfb-database:{{databaseServer}}"
# readyStateText:
port: 8080 # used to poll the application to detect startup
noClean: true
options:
reuseBuild: true

netty:
source:
Expand All @@ -116,7 +125,8 @@ jobs:
dockerContextDirectory: frameworks/Java/netty/
readyStateText: Httpd started
arguments: --add-host="tfb-database:{{databaseServer}}"
noClean: true
options:
reuseBuild: true

vertx:
source:
Expand All @@ -127,7 +137,8 @@ jobs:
dockerContextDirectory: frameworks/Java/vertx/
readyStateText: Server listening
arguments: --add-host="tfb-database:{{databaseServer}}"
noClean: true
options:
reuseBuild: true

spring:
source:
Expand All @@ -138,7 +149,8 @@ jobs:
dockerContextDirectory: frameworks/Java/spring/
readyStateText: Application is ready
arguments: --add-host="tfb-database:{{databaseServer}}"
noClean: true
options:
reuseBuild: true

postgresql:
source:
Expand All @@ -148,7 +160,8 @@ jobs:
dockerImageName: postgres_te
dockerContextDirectory: toolset/databases/postgres
readyStateText: ready to accept connections
noClean: true
options:
reuseBuild: true

mysql:
source:
Expand All @@ -158,7 +171,8 @@ jobs:
dockerImageName: mysql_te
dockerContextDirectory: toolset/databases/mysql
readyStateText: Ready for start up
noClean: true
options:
reuseBuild: true

scenarios:

Expand Down Expand Up @@ -458,6 +472,7 @@ scenarios:
path: /updates?queries=20
serverPort: 8080


cached_queries_vertx:
db:
job: postgresql
Expand Down Expand Up @@ -734,4 +749,3 @@ scenarios:
presetHeaders: json
path: /updates?queries=20
serverPort: 8080

3 changes: 2 additions & 1 deletion src/BenchmarksApps/TechEmpower/BlazorSSR/blazorssr.benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ jobs:
dockerImageName: postgres_te
dockerContextDirectory: toolset/databases/postgres
readyStateText: ready to accept connections
noClean: true
options:
reuseBuild: true

scenarios:
fortunes:
Expand Down
3 changes: 2 additions & 1 deletion src/BenchmarksApps/TechEmpower/Minimal/minimal.benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ jobs:
dockerImageName: postgres_te
dockerContextDirectory: toolset/databases/postgres
readyStateText: ready to accept connections
noClean: true
options:
reuseBuild: true

scenarios:
plaintext:
Expand Down
3 changes: 2 additions & 1 deletion src/BenchmarksApps/TechEmpower/RazorPages/razorpages.benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ jobs:
dockerImageName: postgres_te
dockerContextDirectory: toolset/databases/postgres
readyStateText: ready to accept connections
noClean: true
options:
reuseBuild: true

scenarios:
fortunes:
Expand Down
Loading