Repository navigation
Audit fixes: services after reload, diagnostics redaction, climatisation (0.4.2) - #10
Merged
Merged
Conversation
Must fix - Services climatisation_start/stop disappeared after any reload of the last entry (reauth and reconfigure reload it) until Home Assistant was restarted: they are registered once in async_setup and no longer removed on unload. - Diagnostics leaked the exact position (GPS_LOCATION.location is a "lat,lon" string), the pairing code and key data (BLEID_DDADATA...): those values are now redacted as a whole. - Climatisation is read from HVAC_SUMMARY through pyporscheconnectapi-bartolije 0.5.1 (CLIMATIZER_STATE no longer reports it); the climatisation_start zones come from the same measurement. Should fix - The config flow passes its own HTTP client (no zstd, no blocking SSL setup in the event loop) to the library, reused from the login step to the captcha step. - Errors that are not about the credentials show "cannot_connect" instead of "invalid_auth". - The device tracker is added on a later refresh when the car was in privacy mode at startup. - Removed dead code: unreachable error handling after the first refresh, STARTUP_MESSAGE and its constants, the get_vechicle_data_leaf alias, async_reload_entry, CaptchaRequired, _reauth_entry and the lock's unused door_lock_state_available. Nice to have - The captcha is no longer written to the log. - The climatise switch is disabled by default: the climate entity sends the same command. - Empty picture locations are fetched again once a day instead of on every refresh. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bartolije
pushed a commit
that referenced
this pull request
Nov 6, 2026
The audit fixes merged in #10 ship as 0.5.0 rather than 0.4.2. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from the November 2026 audit, released as 0.4.2. Requires pyporscheconnectapi-bartolije 0.5.1 (bartolije/pyporscheconnectapi#8).
Must fix
climatisation_start/climatisation_stopdisappeared after any reload of the entry (reauth and reconfigure reload it) until Home Assistant restarted. They stay registered now.GPS_LOCATION.locationis a"lat,lon"string), the pairing code and key data. Those values are redacted as a whole.HVAC_SUMMARY(lib 0.5.1):CLIMATIZER_STATEno longer reports it, so the climate entity, switch and services were never available.Should fix
STARTUP_MESSAGEand its constants, unused aliases and attributes).Nice to have: the captcha is no longer logged; the
climatiseswitch is disabled by default (the climate entity sends the same command); empty picture locations are fetched again once a day, not on every refresh.Tests: 76 pass on HA 2026.11.0 with lib 0.5.1 from PyPI. The 7 new tests fail on the previous code. Not tested on a car with remote climatisation.
🤖 Generated with Claude Code