Repository navigation
release/3.x: correct foreign prevout handling (backport #423) - #636
noahjoeris merged 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/3.x #636 +/- ##
===============================================
+ Coverage 81.62% 81.76% +0.14%
===============================================
Files 25 25
Lines 6339 6355 +16
Branches 302 303 +1
===============================================
+ Hits 5174 5196 +22
+ Misses 1056 1052 -4
+ Partials 109 107 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
thunderbiscuit
left a comment
There was a problem hiding this comment.
ACK 9dfc8b4. This is a clean backport.
Claude pointed out to me a small nit which I'll propose here:
The changelog notice in your PR description only mentions the build_fee_bump panic, but this also changes behaviour for users: signing that used to succeed can now return InvalidNonWitnessUtxo, and a caller's witness_utxo can be silently replaced.
It might be worth adding a line, for example: "add_foreign_utxo now overwrites a provided witness_utxo with the prevout from non_witness_utxo, and sign rejects inputs where the two disagree."
|
Thanks, I intentionally wanted to keep this change low key. Probably not necessary tho. Will add it. |
Description
Backport of #423 to
release/3.x.Cherry-picked from master: 5a69e46, d3447f6.
Fixes #345, fixes #556.
Changelog notice
Before submitting