Repository navigation
release/3.x: map keychain in mark_used and unmark_used (backport #507) - #648
Merged
noahjoeris merged 1 commit intoNov 15, 2026
Conversation
`mark_used` and `unmark_used` passed the caller-supplied `KeychainKind` straight to the index. For single-descriptor wallets, this meant marking or unmarking an index on `Internal` was a no-op, since that wallet only tracks the `External` keychain. Route the keychain through `map_keychain` first, consistent with the other methods that take a `KeychainKind`, so a single-keychain wallet resolves `Internal` to `External`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> (cherry picked from commit f66a65e)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/3.x #648 +/- ##
===============================================
+ Coverage 81.65% 81.66% +0.01%
===============================================
Files 25 25
Lines 6345 6349 +4
Branches 304 304
===============================================
+ Hits 5181 5185 +4
Misses 1054 1054
Partials 110 110
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #507 to
release/3.x.Cherry-picked from master: f66a65e.
Changelog notice
Fixed
Wallet::mark_usedandWallet::unmark_useddoing nothing on single-descriptor wallets when passedKeychainKind::Internal.Before submitting