Skip to content

fix(wallet): ignore non-canonical conflicts in TxReplaced events - #649

Open
saket0187 wants to merge 1 commit into
bitcoindevkit:masterfrom
saket0187:fix-tx-replaced-canonical-conflicts
Open

saket0187 wants to merge 1 commit into
bitcoindevkit:masterfrom
saket0187:fix-tx-replaced-canonical-conflicts

Conversation

@saket0187

@saket0187 saket0187 commented Nov 11, 2026 •

Copy link
Copy Markdown

TxReplaced now only lists conflicts that are still canonical. Before, in an RBF chain A→B→C, B was reported as replaced by both A and C, and an evicted replacement was reported as replaced instead of dropped. Related to the "report the winning transaction" part of #616.

Changelog notice

 Fixed `WalletEvent::TxReplaced` listing non-canonical (evicted or replaced) transactions in `conflicts`, and being emitted instead of `WalletEvent::TxDropped` when none of the conflicting transactions is canonical.

Before submitting

Signed-off-by: saket0187 <72020337+saket0187@users.noreply.github.com>
@saket0187
saket0187 requested a review from a team as a code owner November 11, 2026 11:55
@github-project-automation github-project-automation Bot moved this to Triage in BDK Wallet Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant