Skip to content

[PM-45051] Add m5 email templates - #8650

Merged
BTreston merged 2 commits into
mainfrom
ac/pm-45051-milestone-5-email-templates
Oct 22, 2026
Merged

BTreston merged 2 commits into
mainfrom
ac/pm-45051-milestone-5-email-templates

Conversation

@BTreston

@BTreston BTreston commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-45051

📔 Objective

Adds email templates and entry point for milestone 5 email templates.

📸 Screenshots

These are the rendered emails (with placeholder names)

Screenshot 2026-10-20 at 5 04 02 PM Screenshot 2026-10-20 at 5 04 07 PM Screenshot 2026-10-20 at 5 04 12 PM

@BTreston BTreston added ai-review Request a Claude code review t:feature Change Type - Feature Development labels Oct 20, 2026
@github-actions github-actions Bot added the platform-community Touches a Platform-stewarded area with limited team familiarity label Oct 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

ℹ️ Limited Platform familiarity

This PR touches a platform-community area. The Platform team owns this code but does not actively develop it, so a Platform review here may be less authoritative than usual.

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR adds three organization invite reminder email templates. Each has an MJML source plus compiled HTML and text Handlebars views. It also adds SendOrganizationInviteReminderEmailsAsync to IMailService, HandlebarsMailService, and NoopMailService, with unit tests covering subject and template selection, one email per member, and SSO URL construction. The new method follows the SendUpdatedOrganizationInviteEmailsAsync pattern, reuses BuildInvitationUrl, applies PreventEmailAutoLinking to the organization name, renders all interpolations through HTML-escaped {{ }}, and rejects reminder numbers outside 1 to 3.

@codecov

codecov Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 84.61538% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.05%. Comparing base (97daff8) to head (6153a2c).
⚠️ Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
src/Core/Platform/Mail/HandlebarsMailService.cs 91.66% 2 Missing and 1 partial ⚠️
src/Core/Platform/Mail/NoopMailService.cs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8650      +/-   ##
==========================================
+ Coverage   67.01%   67.05%   +0.03%     
==========================================
  Files        2662     2669       +7     
  Lines      113867   113981     +114     
  Branches    10338    10344       +6     
==========================================
+ Hits        76312    76426     +114     
- Misses      35060    35063       +3     
+ Partials     2495     2492       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BTreston
BTreston marked this pull request as ready for review October 20, 2026 21:03
@BTreston
BTreston requested review from a team as code owners October 20, 2026 21:03
@BTreston
BTreston requested review from coroiu and eliykat October 20, 2026 21:03
eliykat
eliykat previously approved these changes Oct 21, 2026

@eliykat eliykat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment is non-blocking.

Comment thread src/Core/Platform/Mail/HandlebarsMailService.cs Outdated
@BTreston
BTreston merged commit 61341c8 into main Oct 22, 2026
49 checks passed
@BTreston
BTreston deleted the ac/pm-45051-milestone-5-email-templates branch October 22, 2026 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review platform-community Touches a Platform-stewarded area with limited team familiarity t:feature Change Type - Feature Development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants