Repository navigation
Propagate TrustedChecksumException in IndexFile - #7515
Open
chrisrueger wants to merge 3 commits into
Open
chrisrueger wants to merge 3 commits into
chrisrueger wants to merge 3 commits into
Conversation
chrisrueger
force-pushed
the
trusted-checksum-show-error-in-build
branch
from
October 31, 2026 06:58
01c548a to
deb02ca
Compare
Ensure TrustedChecksumException is properly thrown rather than silently logged. This includes: - Check result of serialize() in open() and propagate any failure - Rethrow TrustedChecksumException in recover() handler before logging - Rethrow TrustedChecksumException in failed() method before returning failure map Checksum validation failures are critical and should fail the operation. This now really fails the build as well as shows an error in the UI Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
Refactor checksum policy initialization to use constructor parameter instead of setter method. This makes the policy immutable (final field) and simplifies initialization flow in BndPomRepository and MavenBndRepository. The old single-parameter constructor is deprecated in favor of the new one accepting ChecksumPolicy, and setTrustedChecksumsPolicy() is removed from MavenRepository. Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
chrisrueger
force-pushed
the
trusted-checksum-show-error-in-build
branch
from
October 31, 2026 07:07
deb02ca to
3aedd16
Compare
Contributor
Author
|
Now with this PR a gradle build fails with this message. Before the build just failed but not told why. |
Correct documentation to clarify that checksumRecord operates after successful initialization, not during. Add notes on the recommended bootstrap flow: use checksumPolicy=lenient with checksumRecord=true to generate checksums, then switch to strict mode for enforcement. This prevents confusion about initialization order and why strict mode with missing checksums fails before recording can run. Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure TrustedChecksumException is properly thrown rather than silently logged. This includes:
Checksum validation failures are critical and should fail the operation.
This now really fails the build as well as shows an error in the UI