Repository navigation
chore(lint): no ESLint warnings left - #4823
Merged
Merged
Conversation
- components: @typescript-eslint/no-unused-vars, as the core rule reads the parameter names of the TypeScript function types as unused variables - no-console allows console.warn and console.error, the failure reports - the specs and their helpers may declare their stub components inline - dead code removed: functions and variables no template uses anymore - MeteoLayer: the required visible prop has no default Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 58 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | -5 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eslint src e2e "*.mjs"reported 70 warnings on master and reports none with this PR.Config (
eslint.config.mjs).vuefiles: they now use@typescript-eslint/no-unused-varsinstead of the core rule. The core rule reads the parameter names of TypeScript function types in<script lang="ts">as unused variables. Examples areuseTemplateRef<{ show(chunk?: string): void }>andonMapClick?(evt, feature): void. Those false positives made up most of theno-unused-varswarnings.no-console: it now allowsconsole.warnandconsole.error. All 22 hits were failure reports. Theeslint-disablecomments that only allowed them are removed.edition-test-utils.ts:vue/one-component-per-file,vue/require-prop-typesandvue/order-in-componentsare off there, because these files declare small stub components inline.Code
nextTickimport in OlMapshowMountainsListin SubPanelBrasetEditMode/editModein SubPanelCoursecolorExpiredin FfvlLayeruseLayer()call in YetiLayers (it has no side effect)orientations,validity,expiredin AvalancheBox (their template use went away in 2f3e891)visibleprop loses its default (vue/no-required-prop-with-default). Its only caller always passes it.mapDocumentsreadsselectedRouteJourneyonly to depend on it. It now does this withvoid this.currentData.selectedRouteJourney;instead of an unused variable.eslint-disablecomment now names@typescript-eslint/no-unused-vars.Checks
eslint src e2e "*.mjs": no outputvue-tsc --noEmit: passesvitest run: 111 files, 735 tests passvite build: passes🤖 Generated with Claude Code