Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #18
Implements option (a) from the discussion on #18 (agreed with @furkan3152): keep the behaviour exactly as-is and correct the documentation that implied otherwise.
Changes (natspec only, no logic changes)
ContractSignerDisallowedevent — previously documented the address as "no longer allowed to use EIP-1271 signing". Now states that revocation is not enforced on-chain (the contract can still authorize burns via its own ERC-1271 signature, per_wasEverAllowlistedContractSigner).disallowContractSigner—@devsection now explains that new burn intents signed after revocation remain valid, and thatRevokedis kept distinct fromUnallowlistedfor off-chain consumers rather than to stop signing.ContractSignerAllowlistStatus.Revokedenum comment — rewritten to match actual burn-path semantics._wasEverAllowlistedContractSigner— fixed a stale inline typo (RevokedAllowlist→Revoked).No code paths change;
test_burnIntent_withRevokedContractSigner_succeedsand friends still pass unchanged (36/36 behaviour tests in this repo plus the full suite — see below).Testing
forge teston this branch: same result asmaster— 539 passed, 5 failed where all five are toolchain-version artifacts of the local environment (FoundryVersion.t.solpins foundry 1.0.0 vs local 1.5.1;BytecodeMatch.t.solcompares against artifacts compiled with the pinned toolchain). No behavioural test was added because there is no behavioural change; the existing revoked-signer tests are the coverage.