Skip to content

🤖 feat: put the right sidebar's New tab "+" next to the tabs - #7101

Merged
ThomasK33 merged 1 commit into
mainfrom
sidebar-new-tab-plus
Oct 21, 2026
Merged

ThomasK33 merged 1 commit into
mainfrom
sidebar-new-tab-plus

Conversation

@ThomasK33

Copy link
Copy Markdown
Member

Summary

The right sidebar's tab strip has a "+" (New tab) button again, right after the last tab, like the ChatGPT macOS app. Before, New tab was only a row at the bottom of the All tabs (chevron) menu. The chevron menu stays, so tabs that scroll out of view are still one pick away. It now lists every open tab, the New tab too.

Desktop Narrow strip (390px viewport)
Desktop: the "+" sits right after the New tab tab, the chevron and sidebar toggle at the right end Narrow: the tabs scroll and the "+" stays in view before the chevron

Background

#6995 moved New tab into the All tabs menu and removed the strip's "+" on every screen. A New tab hidden in a menu is hard to find, so the "+" is back.

Implementation

  • NewTabButton sits outside the scrolling row, as a sibling of the tablist, so the tablist still owns only tabs. While the tabs fit, it follows the last tab. Once they overflow, the row scrolls and the "+" stays in view.
  • It uses the strip's icon-button style, so it gets the 24px coarse-pointer target and the desktop no-drag region. Its tooltip shows the New tab shortcut (hidden on phones), and it sets aria-keyshortcuts.
  • The All tabs menu has no New tab row now, so no separator is needed.
  • Test helpers (jest UI, Storybook plays, Playwright, bug-bash repros) now open the New tab with the "+".

Validation

  • Storybook interaction tests for the tab strip, RightSidebar, the seeded a11y pages, phone full-screen and phone viewports pass. The tablet touch-target check in .storybook/test-runner.ts now also covers the "+".
  • Jest UI suites: layout/rightSidebar, review/focus, review/baseSelector and chat/contextUsageBoot pass.
  • Bug bash in the sandbox: I ran 5 charters on this branch (mouse, keyboard, overflow plus reload, phone, split panes) with Sonnet 5.5 and the real app AI. They found 0 issues. One run cost $3.48 at list price. The run also gave 2 warnings, and both are older than this PR:
    • The tablist does not handle ArrowLeft and ArrowRight. I filed this as an issue (linked in a comment below).
    • Escape does not close a New tab. I rejected this one, because Escape closes no other tab.

Risks

Low, limited to the right sidebar's tab strip. The "+" takes about 26px from the tab row. On a pane at its minimum width, a long tab (240px) can show cut off at its end. I kept the 10rem cap of titlebar-safe-right-capped: a larger cap would put strip controls under the Windows/Linux window controls at the 300px minimum width. So these stories now check what still holds:

  • Narrow is 330px wide (was 300px), so its 240px tab still fits beside "+" and All tabs.
  • TabsReachableUnderWideTitlebarInset checks that the selected tab can be clicked, not that it is fully visible.

Generated with xum • Model: anthropic:claude-opus-5-5 • Thinking: high • Cost: $3.03

The All tabs menu lists every open tab (the New tab too) and no longer
holds a New tab row. Test helpers open the New tab with the "+".
@mintlify

mintlify Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
Mux 🟢 Ready View Preview Oct 21, 2026, 9:14 AM

💡 Tip: Enable Automations to automatically generate PRs for you.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-21T09:17:29.744959Z e44439e Manual request
🔒 Security Review ✅ Completed 2026-10-21T09:17:27.924377Z e44439e Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ThomasK33

Copy link
Copy Markdown
Member Author

Bug bash follow-up: the keyboard explorer's arrow-key warning is older than this PR. I filed it as #7102.

@ThomasK33

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: e44439ec74

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: e44439ec74

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ThomasK33

Copy link
Copy Markdown
Member Author

Readiness record for head e44439ec74:

@ThomasK33
ThomasK33 added this pull request to the merge queue Oct 21, 2026
Merged via the queue into main with commit f3eb883 Oct 21, 2026
34 of 35 checks passed
@ThomasK33
ThomasK33 deleted the sidebar-new-tab-plus branch October 21, 2026 09:43

This branch was successfully deployed

1 active deployment
staging - docs — e44439ec Deployed Oct 21, 2026 by mintlify[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant