Repository navigation
Conversation
Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
ktock
force-pushed
the
bumpup-stargz
branch
3 times, most recently
from
October 15, 2026 06:01
8db30d2 to
4607ae8
Compare
AkihiroSuda
reviewed
Oct 15, 2026
| @@ -0,0 +1,39 @@ | |||
| //go:build linux | |||
AkihiroSuda
reviewed
Oct 15, 2026
| tags.cncf.io/container-device-interface/specs-go v1.1.1 // indirect | ||
| ) | ||
|
|
||
| require ( |
Member
There was a problem hiding this comment.
Should be merged to the existing require() group
AkihiroSuda
reviewed
Oct 15, 2026
| github.com/prometheus/common v0.71.0 // indirect | ||
| github.com/prometheus/procfs v0.21.1 // indirect | ||
| go.etcd.io/bbolt v1.5.0 // indirect | ||
| k8s.io/cri-api v0.37.1 // indirect |
Member
There was a problem hiding this comment.
CRI shouldn't be dependent here?
AkihiroSuda
reviewed
Oct 15, 2026
| github.com/prometheus/client_golang v1.24.1 // indirect | ||
| github.com/prometheus/client_model v0.6.3 // indirect | ||
| github.com/prometheus/common v0.71.0 // indirect | ||
| github.com/prometheus/procfs v0.21.1 // indirect |
Member
There was a problem hiding this comment.
Prometheus shouldn't be dependent here?
AkihiroSuda
reviewed
Oct 15, 2026
| github.com/beorn7/perks v1.0.1 // indirect | ||
| github.com/docker/go-metrics v0.1.0 // indirect | ||
| github.com/golang/groupcache v0.0.0-20241129210726-2c02b8208cf8 // indirect | ||
| github.com/hanwen/go-fuse/v2 v2.11.0 // indirect |
Member
There was a problem hiding this comment.
go-fuse shouldn't be dependent here?
AkihiroSuda
reviewed
Oct 15, 2026
| assert.NilError(t, err) | ||
| } | ||
|
|
||
| func newTestContainerdClient(helpers test.Helpers) *containerd.Client { |
Member
There was a problem hiding this comment.
If this helper function is useful for non-stargz tests, it should be moved out of *_stargz_*_test.go
Member
|
CI is failing |
Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com> Assisted-by: Claude Sonnet 5.5
Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com> Assisted-by: Claude Sonnet 5.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5262