Repository navigation
feat(sdk): let the host configure the upload size limit - #51
Merged
Merged
Conversation
Config.uploadMaxFileSize reaches the uploads plugin as maxFileSize. The default stays 10 MB. A host that takes video attachments needs more: a 15-second 1080p clip straight from an editor is about 20 MB. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Config.uploadMaxFileSize(bytes). It reaches the uploads plugin asmaxFileSizethrough the same path asuploadArchiveLimits:bootstrap→createSystem→SessionManager→ plugin config.validateConfigrejects a value that is not a positive safe integer.File too largemessage names the configured limit.Why: a host that accepts video attachments needs more than 10 MB. A 15-second 1080p clip exported from an editor is about 20 MB.
Verification:
ts:build,tsc -p packages/sdk/tsconfig.test.json, lint, anduploads.integration.test.ts(26 pass, including the new test for a 20 MB limit).🤖 Generated with Claude Code