Repository navigation
refactor(build): keep the native library file names in one module - #362
Open
fwittreverce wants to merge 1 commit into
Open
fwittreverce wants to merge 1 commit into
fwittreverce wants to merge 1 commit into
Conversation
The file names of the native library were spelled out in four places: PLATFORM_FOLDERS in setup.py, dynamically_load_library() in lib.py, _lib_name_default in c2pa.py and LIB_NAMES in scripts/build_local_artifacts.py. src/c2pa/_library_names.py now holds them, keyed by sys.platform, and the loader and c2pa.py share its get_library_name(). setup.py and the build script read the mapping with runpy.run_path(), because importing the c2pa package loads the native library. Follow-up to contentauth#356.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The file names of the native library were spelled out in four places: PLATFORM_FOLDERS in setup.py, dynamically_load_library() in lib.py, _lib_name_default in c2pa.py and LIB_NAMES in
scripts/build_local_artifacts.py. src/c2pa/_library_names.py now holds them, keyed by sys.platform, and the loader and c2pa.py share its get_library_name(). setup.py and the build script read the mapping with runpy.run_path(), because importing the c2pa package loads the native library.
Follow-up to #356.
Changes in this pull request
Give a narrative description of what has been changed.
Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.