Repository navigation
fix(ci): report real errors from the snapshot editor permission check - #702
Farhan (farhankhalaf) wants to merge 1 commit into
Conversation
The trusted-editor guard mapped every GitHub API failure to "none", so a 403, rate limit or 5xx read as missing access. Only a 404 (no such user) now maps to "none"; any other failure stops with the API's own error. The guard still fails closed in every case. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
[Low impact] The PR appears safe to merge. SummaryUpdates the snapshot editor check to distinguish missing access from API failures.
Reviews (1) · Last reviewed commit: "fix(ci): report real errors from the sna..." · Reviewed by Greptile |
📋 PR Overview
🔬 Coverage
|
🎨 Storybook previewUpdated for c3afc32
|








Summary
Follow-up to #698. The trusted-editor guard in Update Snapshots turned every failed collaborator-permission lookup into
none, so a 403, rate limit or 5xx read as "has 'none' access". Only a 404 (no such user) now maps tonone; any other failure stops with GitHub's own error. The guard still fails closed in every case.#no-linear
Test Plan
ghfor write, read, none, 404, 403, 500 and network failures, plus a fork head repo. Write passes; read, none and 404 report missing access; 403, 500 and network failures report the real error; the fork fails the same-repo check.arcrunner label.Docs
🤖 Generated with Claude Code
https://claude.ai/code/session_01GziRseGZMsJ5Yf7EboZLMc
Summary by cubic
Fixes the snapshot editor permission check in the update-snapshots workflow so 403s, rate limits, and 5xx errors now stop the job with GitHub's real error, instead of being read as "none" access. Only a 404 (no such user) maps to "none"; the guard still fails closed in every case.
Written for commit c3afc32. Summary will update on new commits.