Repository navigation
fix: read an absent PostScript metadataLength as zero - #94
Open
ahed-jneed wants to merge 1 commit into
Open
ahed-jneed wants to merge 1 commit into
ahed-jneed wants to merge 1 commit into
Conversation
orc.proto declares metadataLength optional, and a writer that emits no stripe statistics may omit it; an absent field means a zero-length Metadata section. read_metadata and read_metadata_async rejected such files with "Metadata length is empty". Read the field as 0 in both; footerLength stays required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
orc.protodeclaresPostScript.metadataLengthoptional, and an absent field means a zero-length Metadata section. Some writers that emit no stripe statistics omit it.read_metadataandread_metadata_asyncrejected those files withMetadata length is empty.This reads the field as 0 in both.
footerLengthstays required.Adds sync and async tests that write a file, strip
metadataLengthfrom its PostScript, and read it back.cargo fmt --all -- --checkandcargo clippy --workspace --all-targets -- -D warnings(default,--no-default-features,--all-features) pass.cargo test --all-features --no-fail-fastpasses except the 14tests/binCLI snapshot tests, which fail identically onmainon Windows (path/line-ending differences in the expected output).