Repository navigation
feat: record the outputs_to_string tool result on the Agent tool span - #13720
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
anakin87
approved these changes
Nov 12, 2026
anakin87
left a comment
Member
There was a problem hiding this comment.
I tried to understand the impact of the change regarding moving the message conversion step but I could not find obvious issues.
Could you add one/two sync/async tests (or adapt the existing tests) for a failing outputs_to_stringhandler? Ideally, it should cover error propagation and tool span creation/closing...
Contributor
Author
|
Done in dd167d8 |
…s_to_string handler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
outputs_to_stringresult the LLM actually received.Proposed Changes:
haystack.agent.step.toolspan gets a newhaystack.agent.step.tool.resultcontent tag with the result string sent to the LLM.haystack.agent.step.tool.outputstill holds the raw tool return value.gen_ai.tool.call.resultconcept on theexecute_toolspan.How did you test it?
Updated the tool span tag test and added sync/async tests with an
outputs_to_stringhandler.Notes for the reviewer
*.input/*.outputtags, so showing the new tag there needs a follow-up in core-integrations (Rhesis likewise).raise_on_failure=True, the error is now raised inside the tool span. The failing call'soutputs_to_statemerge no longer runs before the raise.Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.