Repository navigation
fix: pass inputs_from_state values to ComponentTool components without conversion - #13812
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
anakin87
approved these changes
Nov 19, 2026
anakin87
left a comment
Member
There was a problem hiding this comment.
Looks good
I haven't found a realistic use case where this change could cause problems.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Secretas a State type passed toComponentToolviainputs_from_state#13684Proposed Changes:
ComponentToolran values mapped throughinputs_from_statethrough_convert_param, which uses Pydantic'sTypeAdapter. Pydantic can't build a schema forSecret, so a component input typedstr | Secretfailed whether State held astror aSecret.Secret, since State values appear in the Agent result, content traces and tool error messages. ASecretshows as<redacted>in all of them.How did you test it?
New parametrized unit test (
strandSecretState values), plus manualAgentruns withstate_schema={"access_token": {"type": Secret}}checking the token never appears in tool errors, logs or content traces.Notes for the reviewer
The skip applies to every parameter mapped from State, so if custom
parametersalso show that parameter to the LLM and the LLM fills it in, that value isn't converted either.Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.