Skip to content

LEGO: Pull request from lego/hb_5df43909-4a19-4f55-bc3f-9ea8fccf3c82_20261101053540531 to main - #27232

Open
csigs wants to merge 1 commit into
mainfrom
lego/hb_5df43909-4a19-4f55-bc3f-9ea8fccf3c82_20261101053540531
Open

csigs wants to merge 1 commit into
mainfrom
lego/hb_5df43909-4a19-4f55-bc3f-9ea8fccf3c82_20261101053540531

Conversation

@csigs

@csigs csigs commented Nov 1, 2026

Copy link
Copy Markdown
Member

LEGO: Pull request from lego/hb_5df43909-4a19-4f55-bc3f-9ea8fccf3c82_20261101053540531 to main with localized lcls

Copilot AI balanced review requested due to automatic review settings November 1, 2026 05:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the localized MSBuild diagnostic updates.

No open issues 🎉

What changed in this PR

Updates localized MSBuild diagnostics for .NET for Apple platforms through the localization pipeline. No runtime or build logic changes are included.

Changes:

  • Adds Traditional Chinese and Polish translations for the scene lifecycle requirement diagnostic (E7199).
  • Adds Traditional Chinese, Polish, and Korean translations for device enumeration failures (E7200).
  • Renames the framework-extension warning key from W7199 to W7200 in Traditional Chinese and Polish resources.
File Description
macios/​Localize/​loc/​zh-Hant/​macios/​msbuild/​Xamarin.Localization.MSBuild/​MSBStrings.resx.lcl Adds two Traditional Chinese diagnostics and updates the warning key.
macios/​Localize/​loc/​pl/​macios/​msbuild/​Xamarin.Localization.MSBuild/​MSBStrings.resx.lcl Adds two Polish diagnostics and updates the warning key.
macios/​Localize/​loc/​ko/​macios/​msbuild/​Xamarin.Localization.MSBuild/​MSBStrings.resx.lcl Adds the Korean device enumeration failure diagnostic.

Review effort: Balanced

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: e5d27a4cd73a1fd963bf718f938f671cca08c2fe [PR build]

@vs-mobiletools-engineering-service2

Copy link
Copy Markdown
Collaborator

🔥 [CI Build #e5d27a4] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 28 tests failed, 189 tests passed.

Failures

❌ monotouch tests (iOS)

13 tests failed, 7 tests passed.

Failed tests

  • monotouch-test/iOS - simulator/Release (all optimizations): Failed
  • monotouch-test/iOS - simulator/Release (NativeAOT): Failed
  • monotouch-test/iOS - simulator/Release (trimmable static registrar, NativeAOT): Failed
  • monotouch-test/iOS - simulator/Debug (managed static registrar): Failed
  • monotouch-test/iOS - simulator/Debug (trimmable static registrar): Failed
  • monotouch-test/iOS - simulator/Release (managed static registrar, all optimizations): Failed
  • monotouch-test/iOS - simulator/Debug (trimmable static registrar, all optimizations): Failed
  • monotouch-test/iOS - simulator/Release (trimmable static registrar, all optimizations): Failed
  • monotouch-test/iOS - simulator/Release (compat inline Class.GetHandle): Failed
  • monotouch-test/iOS - simulator/Release (strict inline Class.GetHandle): Failed
  • monotouch-test/iOS - simulator/Release (compat inline dlfcn): Failed
  • monotouch-test/iOS - simulator/Release (strict inline dlfcn, link sdk): Failed
  • monotouch-test/iOS - simulator/Release (NativeAOT, .NET 11 defaults): Failed

Html Report (VSDrops) Download

❌ monotouch tests (macOS)

2 tests failed, 18 tests passed.

Failed tests

  • monotouch-test/macOS/Release (compat inline dlfcn): Failed (Test run failed.
    Tests run: 4154 Passed: 4004 Inconclusive: 14 Failed: 3 Ignored: 147)
  • monotouch-test/macOS/Release (strict inline dlfcn, link sdk): Failed (Test run failed.
    Tests run: 4154 Passed: 4003 Inconclusive: 14 Failed: 3 Ignored: 148)

Html Report (VSDrops) Download

❌ monotouch tests (tvOS)

13 tests failed, 7 tests passed.

Failed tests

  • monotouch-test/tvOS - simulator/Release (all optimizations): Failed
  • monotouch-test/tvOS - simulator/Release (NativeAOT): Failed
  • monotouch-test/tvOS - simulator/Release (trimmable static registrar, NativeAOT): Failed
  • monotouch-test/tvOS - simulator/Debug (managed static registrar): Failed
  • monotouch-test/tvOS - simulator/Debug (trimmable static registrar): Failed
  • monotouch-test/tvOS - simulator/Release (managed static registrar, all optimizations): Failed
  • monotouch-test/tvOS - simulator/Debug (trimmable static registrar, all optimizations): Failed
  • monotouch-test/tvOS - simulator/Release (trimmable static registrar, all optimizations): Failed
  • monotouch-test/tvOS - simulator/Release (compat inline Class.GetHandle): Failed
  • monotouch-test/tvOS - simulator/Release (strict inline Class.GetHandle): Failed
  • monotouch-test/tvOS - simulator/Release (compat inline dlfcn): Failed
  • monotouch-test/tvOS - simulator/Release (strict inline dlfcn, link sdk): Failed
  • monotouch-test/tvOS - simulator/Release (NativeAOT, .NET 11 defaults): Failed

Html Report (VSDrops) Download

Successes

✅ assembly-processing: All 1 tests passed. Html Report (VSDrops) Download
✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 1 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker (iOS): All 21 tests passed. Html Report (VSDrops) Download
✅ linker (MacCatalyst): All 21 tests passed. Html Report (VSDrops) Download
✅ linker (macOS): All 21 tests passed. Html Report (VSDrops) Download
✅ linker (tvOS): All 21 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 20 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Golden Gate (27): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

✅ Linux build succeeded

Pipeline on Agent
Hash: e5d27a4cd73a1fd963bf718f938f671cca08c2fe [PR build]

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants