Repository navigation
feat(querymodifier): add opt-in query parameter sorting and generated tests - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add opt-in query-parameter ordering without changing existing filtering behavior:
Sorting is stable: repeated names retain their value order. Names are compared as raw, case-sensitive strings; nothing is URL-decoded. Callers should opt in only when their origin treats reordered parameters the same way. This does not change a consumer's VCL automatically.
Add VTC coverage for cache-key sharing and duplicate-name order, plus a seeded differential harness that checks the built VMOD against an independent query-string model. Refresh the Docker build to use the Docker Hub Varnish 8.0.2 Alpine image and run both suites.
Evidence
2026). Local Varnish 9.1 passed the same VTC suite and generated runs with seeds2026and17.Merge Danger
Door: Two-way. Existing entry points keep their behavior; callers must explicitly use the new functions. Reverting the VMOD change is straightforward before consumers adopt it.
Blast Radius: VMOD consumers opting into sorted URLs. Reordering can change meaning for origins that interpret distinct query parameters in order; repeated raw-name values remain stable, but URL-encoded aliases are not decoded or unified.