Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue is this addressing?
None
What type of issue is this addressing?
bug
What this PR does | solves
A source that blocks in Seek holds the player mutex needed by mixing and player queries. Release that mutex around the external Seek while serializing source reads, seeks and state-changing player controls. Preserve buffer invalidation and playback restoration; cleanup waits at the outer Close rather than the internal error-close path.
Validation: Native macOS arm64 internal race tests passed, including shuffle/count=3 and the final blocked-Read regression. The new mixer/getter regression fails on the actual base and passes after the fix. Tests cover controls, two seeks, source Read exclusion, stale Read results, errors and panics. Native build and Windows amd64 cross-build passed. State-changing controls still wait for a blocked Seek; this fixes mixer/query progress.