Repository navigation
js: fill worklet requests with at least one render quantum - #331
Merged
hajimehoshi merged 1 commit intoOct 26, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue is this addressing?
None
What type of issue is this addressing?
bug
What this PR does | solves
With a context buffer smaller than a worklet output block, each response can be too short and the processor repeatedly returns silence while accumulating data. Send the actual output frame count with each request and grow the Go transfer buffer to cover it. Request the next batch before consuming the final block. ScriptProcessor sizing and the configured/default context sizes remain unchanged.
Validation: An actual Go JS/Wasm executable and the unchanged embedded worklet were run with browser APIs substituted in Node. For a 12-frame stereo context buffer, the base produced 1/18 and 0/18 complete steady-state blocks for 128- and 512-frame outputs; the fix produced 18/18 in both cases and sent full-quantum transfers. Native internal race tests, JS/Wasm build and vet passed. This verifies the undersized-transfer path, not real-browser scheduling, native playback or immunity to underruns.