Repository navigation
ci: add pull-request checks - #105
Merged
Merged
Conversation
Run Prettier and ESLint on changed code files, the hub card check, the type check and the build on pull requests to master and develop and on pushes to master. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
.github/workflows/ci.yml: one job on pull requests tomasteranddevelopand on pushes tomaster, with concurrency that cancels an older run of the same ref.What runs
packageManager(10.29.3), Nodelts/*with the pnpm store cache,pnpm install --frozen-lockfile..js/.jsx/.ts/.tsx/.mjs/.cjs/.cssfiles changed against the base branch (git diff --name-only --diff-filter=d origin/<base>...HEAD).--max-warnings 0 --no-warn-ignored.node scripts/check-hub-cards.mjs: new dependency-free script; fails when a card inlib/hub-data/generators/has no singleslug, a slug that differs from its file name, a duplicate slug, or is not imported inlib/hub-data/index.ts.pnpm types:check.pnpm build.Why changed files only
The repository is not clean on current
master:prettier --check .reports 260 files: 208 of 218.mdx, all 26.json, 4.md, 20.ts/.tsx. MDX, JSON and Markdown are not kept in Prettier style, so they are left out of the check; otherwise nearly every content PR would fail on formatting it did not introduce.pnpm lint --max-warnings 0reports 79 errors in 33 files (12 components/routes/scripts, 21 hub cards).A whole-repository check can replace the diff once these are cleaned up.
Note: 21 hub cards fail
sonarjs/no-hardcoded-ip(sample events contain IP addresses) orunicorn/prefer-string-raw. A PR that adds or edits a card with sample IPs will fail ESLint until that rule is disabled forlib/hub-data/generators/**or the line is suppressed.Local results on this branch (master + this commit)
pnpm install --frozen-lockfilecheck-hub-cards.mjspnpm types:checkpnpm build🤖 Generated with Claude Code