Repository navigation
[build-tools] Extract a shared worker API client from the device run session client - #4806
Open
AHGIJMKLKKZNPJKQR wants to merge 1 commit into
Open
AHGIJMKLKKZNPJKQR wants to merge 1 commit into
AHGIJMKLKKZNPJKQR wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4806 +/- ##
==========================================
+ Coverage 76.64% 76.65% +0.01%
==========================================
Files 1102 1103 +1
Lines 55495 55499 +4
Branches 12236 12232 -4
==========================================
+ Hits 42530 42535 +5
+ Misses 11976 11975 -1
Partials 989 989 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
AHGIJMKLKKZNPJKQR
changed the title
AHGIJMKLKKZNPJKQR
force-pushed
the
tom/worker-api-core
branch
from
November 3, 2026 16:00
f7ffce6 to
5d61815
Compare
AHGIJMKLKKZNPJKQR
marked this pull request as ready for review
November 3, 2026 16:41
AHGIJMKLKKZNPJKQR
force-pushed
the
tom/worker-api-core
branch
from
November 4, 2026 12:00
5d61815 to
7f7ee6f
Compare
|
✅ Thank you for adding a changeset! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Sandboxes will use the same "worker API" mechanism as device run sessions and we want to reuse the code.
How
Created a
WorkerAPIinterface, which owns the retrying and auth of when making requests to www.DeviceRunSessionWorkerAPIuses it. We're essentially just moving code around, without making actual changes in this PRTest Plan
CI passes, existing tests pass, since we expect no behavior changes