Repository navigation
Conversation
`eas workflow:run <file>` uploads the local project, so the run carries no branch or commit and the EAS dashboard cannot list it under a branch. The two flags record the branch and commit the uploaded project comes from. They must be given together and cannot be combined with `--ref`. The server verifies the commit in the project's linked GitHub repository and reads the commit message from GitHub. Generated GraphQL types come from production plus the pending www schema change, so the diff also carries unrelated schema drift.
|
✅ Thank you for adding a changeset! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4815 +/- ##
==========================================
+ Coverage 76.64% 76.65% +0.01%
==========================================
Files 1102 1102
Lines 55495 55505 +10
Branches 12236 12238 +2
==========================================
+ Hits 42530 42540 +10
Misses 11976 11976
Partials 989 989 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
eas workflow:run <file>uploads the local project, so the run carries no branch or commit and the EAS dashboard cannot list it under a branch. Affirm asked for this (ENG-28709); server side is expo/universe#33199.How
--git-branchand--git-commit-hash, paired with oclifdependsOnand exclusive with--ref.gitfield when the flags are unset, so requests stay unchanged for current users and older servers.Draft note:
verify-graphql-codefails until expo/universe#33199 is deployed.Test Plan
Added unit coverage for the flag helper and for the
gitinput passed to the mutation, and ran the built binary to confirm the flag errors fire before login. Also ranyarn typecheck,yarn test,yarn fmt:check,yarn lint, and the changeset check.