Repository navigation
test(visual): adopt the RichText stable story baselines - #7574
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
AI review status for this pull request.
|
PR Analysis Report📚 Storybook Preview🧪 Sandbox PreviewNo new or modified components detected. Bundle Size SummaryNo component packages changed. Accessibility AuditStatus: No accessibility violations detected. Visual Regression38 of 474 shot(s) changed. A change here is a question, not a failure: check whether the after is the
and 18 more. Generated by PR Enrichment workflow | Storybook | Sandbox | View full report |
There was a problem hiding this comment.
Recommending approval: the four RichText baseline images come from the full-plan main capture, the manifest matches what gate.mjs accept writes, and this pull request's own visual-regression run reproduces all four images exactly, so they now compare as unchanged instead of added. No changes are needed. One small description correction: core-markdown--default__probe-light and -dark drop out of the probe plan because the newly stable Markdown parity story covers all of their theming targets, so not every other removed key is unrelated; leaving them for a later maintenance pass is fine.
[Automated review]
Maintainer impact
@astryxdesign/richtextbecame a stable package in #7224, so its two stable Storybook stories (RichText/RichTextEditorDefault and Markdown parity) entered the canonical visual plan with no accepted baseline. Every visual comparison reports them asadded, which is baseline debt: a later change to either story would have no before image to compare against.Intended invariant
The visual gate's maintenance path (
.github/scripts/visual-gate/README.md, "Maintenance"): a reviewed capture of exactmain, promoted withgate.mjs acceptfor named keys, through a pull request that contains only the baseline delta.Change
Adopts four shots from the validated candidate of CI run 38736912098 (
operation=captureonmainat 2274345, the #7224 merge):richtext-richtexteditor--default__neutral-light/__neutral-darkrichtext-richtexteditor--markdown-parity__probe-light/__probe-darkOnly those keys are promoted. The same capture also reports 86 other added, 38 changed and 36 removed shots for unrelated components; none of those is accepted or pruned here.
Evidence
added, with no baseline entry..github/visual-baseline/manifest.jsongains exactly those four keys (no other shot entry changes) plus the capture context and one acceptance decision; the four PNGs are the candidate's bytes, re-hashed byaccept.Scope
Testing