Repository navigation
Conversation
Contributor
|
@kinto0 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D125113437. |
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
…5226) Summary: Stack context: Make the language server answer startup requests with the client's workspace settings instead of default settings. - This diff adds VS Code extension tests that run the real extension, the Python extension (`ms-python.python`), and the server. A small stdio shim between VS Code and the server controls the client's `workspace/configuration` responses. In `instant` mode, the shim forwards them at once. In `delay` mode, the shim holds them for 3 seconds, as a slow Python extension does. In `drop` mode, the shim discards the first response. - The Rust tests in this stack drive the server with a scripted client. These tests check the same behavior with the requests, the settings, and the interpreter that VS Code and the Python extension really send. With `instant` and `delay`, go-to-definition at startup must resolve into the virtual environment that only the Python extension names, and every diagnostic set that VS Code shows must come from the workspace settings. `delay` also checks that the definition request reached the server before the settings did. With `drop`, the server must still answer at startup. - The workspaces are built in a temporary directory, because Pyrefly finds a virtual environment near a project without the client's settings. Differential Revision: D125113437
meta-codesync
Bot
changed the title
kinto0
force-pushed
the
export-D125113437
branch
from
October 14, 2026 18:33
20daec8 to
2fac842
Compare
stroxler
approved these changes
Oct 15, 2026
stroxler
left a comment
stroxler
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Contributor
|
This pull request has been merged in 4b07099. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Stack context: Make the language server answer startup requests with the client's workspace settings instead of default settings.
ms-python.python), and the server. A small stdio shim between VS Code and the server controls the client'sworkspace/configurationresponses. Ininstantmode, the shim forwards them at once. Indelaymode, the shim holds them for 3 seconds, as a slow Python extension does. Indropmode, the shim discards the first response.instantanddelay, go-to-definition at startup must resolve into the virtual environment that only the Python extension names, and every diagnostic set that VS Code shows must come from the workspace settings.delayalso checks that the definition request reached the server before the settings did. Withdrop, the server must still answer at startup.Differential Revision: D125113437