Repository navigation
fix LSP: Go to Definition on nn.Module calls should navigate to forward() #5229 - #5238
Closed
asukaminato0721 wants to merge 3 commits into
Closed
asukaminato0721 wants to merge 3 commits into
asukaminato0721 wants to merge 3 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
stroxler
requested changes
Oct 15, 2026
This comment has been minimized.
This comment has been minimized.
Contributor
|
I think this looks good. Could you try one more rebase? We had an outage in the auto-importer, I think it should be cleared now |
Contributor
|
This pull request has been imported. If you are a Meta employee, you can view this in D125585686. (Because this pull request was imported automatically, there will not be any future comments.) |
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
stroxler
approved these changes
Oct 16, 2026
stroxler
left a comment
stroxler
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Contributor
|
This pull request has been merged in 631f81e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PyTorch module calls now navigate to forward(), including inherited and overridden methods. Explicit
__call__navigation still works.Fixes #5229
Test Plan
add test