Repository navigation
[local_auth_darwin] Fix Swift 6 concurrency analyzer errors from lifecycle delegate methods - #13296
Conversation
…cycle delegate methods
| // and applicationDidBecomeActive for apps that haven't migrated yet. | ||
| #if os(iOS) | ||
| @MainActor | ||
| public func sceneDidBecomeActive(_ scene: UIScene) { |
| } | ||
|
|
||
| @MainActor | ||
| public func applicationDidBecomeActive(_ application: UIApplication) { |
There was a problem hiding this comment.
|
In general, I would expect that getting plugins to compile cleanly in strict mode is going to be pretty messy until the engine is fixed to annotate its protocols. The engine contract has always been to call method on the main thread, and plugins assume (and often need) that, but the annotations aren't in place. Doing it in the other order in all plugins will probably require a bunch of workarounds. |
There was a problem hiding this comment.
Code Review
This pull request updates the local_auth_darwin package to version 2.0.5. It removes the @MainActor attribute from the sceneDidBecomeActive and applicationDidBecomeActive methods in LocalAuthPlugin.swift, and updates the CHANGELOG.md and pubspec.yaml files. There are no review comments, and I have no feedback to provide.
I'm sure there's a lot more to do here, I'm currently wack-a-moleing the errors from flutter/flutter#194594 so we can get that fixed asap. There really weren't that many swift 6 errors though. |
FlutterApplicationLifeCycleDelegate/FlutterSceneLifeCycleDelegateprotocol requirements are nonisolated, removeMainActor.From #10836
Fixes flutter/flutter#194594
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2