Repository navigation
[flux/v2.10.x] http/fetch: Add typed error for digest mismatch - #1349
Merged
Merged
Conversation
Wrap the digest verification failure with ErrDigestMismatch so that callers can tell when the downloaded artifact does not match the advertised digest. This happens when a source artifact is rebuilt between reading the source status and downloading it, e.g. after source-controller restarts with ephemeral storage. Controllers can retry these errors like ErrFileNotFound instead of waiting for the next reconciliation interval. Drop the max download size hint from the error message, as exceeding the limit is reported by a dedicated error before verification. Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com> (cherry picked from commit 0d49a19)
matheuscscp
approved these changes
Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated backport to
flux/v2.10.x, triggered by a label in #1348.