Skip to content

ref(nav): Remove unreachable SDKs dropdown - #19930

Open
mydea wants to merge 1 commit into
masterfrom
fn/remove-dead-sdks-dropdown
Open

mydea wants to merge 1 commit into
masterfrom
fn/remove-dead-sdks-dropdown

Conversation

@mydea

@mydea mydea commented Oct 13, 2026

Copy link
Copy Markdown
Member

DESCRIBE YOUR PR

Stacked on #19928.

TopNavClient contains a platform picker popup for "SDKs", but it can never open: its open state is only ever set to false, and the ref for its trigger button is never attached. "SDKs" has been a plain link since the nav redesign (#14178).

This removes the popup and the PlatformSelector modes only it used (listOnly, alwaysOpen, dropdownStyle). No visible change.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.
Select exactly one option. For deadlines, replace YYYY-MM-DD with the due date. You can update this information later by editing the PR description.

  • Urgent deadline (GA date, etc.): YYYY-MM-DD
  • Other deadline: YYYY-MM-DD
  • No deadline: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've supplied a deadline.

Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

🤖 Generated with Claude Code

@vercel

vercel Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
develop-docs Ready Ready Preview Oct 15, 2026 7:59am UTC
sentry-docs Ready Ready Preview Oct 15, 2026 7:59am UTC

Request Review

@cursor

cursor Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

The plan checks platform-page traffic, client errors, and stack frames from the top nav and platform picker. An issue escalates when those stack frames appear or platform-page traffic falls.

Services: sentry-docs.

Mention @change-monitor in a comment to update the plan.

Plan

What changed

The top nav SDKs item stays a plain link to platform docs. The unused SDK popup is gone. The sidebar platform picker still uses the remaining select control. This change is live after sentry-docs deploys. Catalog and the Vercel production deploy report both name sentry-docs.

Risk

PlatformSelector still serves the sidebar. A bad cleanup can stop platform switches on SDK pages. Concepts and Manage menus share this top-nav file and position hook. A hook mistake can hide those menus on every page.

Intended effect

This cleanup adds no new metric. The popup never opened, so telemetry cannot show that it is gone. Use sampled platform-page traffic as the reachable proxy that the SDKs link and sidebar picker still reach platform docs. Absent looks like that share falling while all-page navigation holds. Traces are sampled at 30 percent. Compare sampled TPM, not raw users.

Signal Baseline Window Rule Source
Share of pageload and navigation spans whose transaction or URL contains /platforms/ 48-50% of sampled pageload and navigation spans 2026-10-12T08:00:00Z to 2026-10-14T07:00:00Z hold in band Sentry org sentry project docs environment production. Query span.op:[pageload, navigation] environment:production (transaction:*/platforms/* OR url.full:*/platforms/*) over environment:production span.op:[pageload,navigation]. 48h totals 18327 / 38147.
Sampled TPM for those /platforms/ pageload and navigation spans 6.3-6.7 TPM 2026-10-12T08:00:00Z to 2026-10-14T07:00:00Z hold in band Same source. Prior complete hours about 6.3 TPM. Latest complete 24h 9672 spans, 6.7 TPM.

Regression watch

A bad deploy can break the shared picker, the SDKs link, or sibling top-nav menus. Watch client error volume and stack frames in the changed files. Current top titles are mostly Algolia fetch noise and /:path*? culprits. Do not treat those as this change unless they rise with new TopNav or picker frames.

Signal Baseline Window Rule Source
Production client error events 170-190 events per 24h. 24h mean 7.2-7.8 events per hour. Hourly values 0-26 2026-10-12T08:00:00Z to 2026-10-14T07:26:00Z hold near the 24h band. Escalate if 24h count rises above 280 Sentry org sentry project docs environment production. Query environment:production with count(). Latest 24h 185 events. Prior 23h 174 events.
Error events with stack filename platformSelector or TopNavClient 0 events 2026-10-12T07:26:00Z to 2026-10-14T07:26:00Z hold at 0 Same project. Query environment:production AND (stack.filename:"*platformSelector*" OR stack.filename:"*TopNavClient*"). Zero across 48h.
Sampled TPM for all pageload and navigation spans 12.8-13.7 TPM 2026-10-12T08:00:00Z to 2026-10-14T07:26:00Z hold in band Same project. Query environment:production span.op:[pageload,navigation]. Latest 24h 19760 spans. Prior 24h about 18387 spans.

If the specific stack frames rise, inspect TopNav Concepts and Manage menus and the sidebar picker on /platforms/ pages.

Not observable

Telemetry cannot show that the popup is gone. No click event exists for the SDKs link. Error events use transaction /:path*?, so they cannot isolate /platforms/ pages. Concepts and Manage open state have no signal. p95 duration for /platforms/ spans did not return a value.

Get Slack DMs about this change: cursor.com/automations/rollouts

Base automatically changed from fn/lazy-platform-list to master October 15, 2026 07:53
The top nav had a platform picker popup for "SDKs", but nothing ever opened
it: its open state was only ever set to false and its trigger ref was never
attached. "SDKs" has been a plain link since the nav redesign.

Remove the popup and the PlatformSelector modes only it used (listOnly,
alwaysOpen, dropdownStyle).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@coolguyzone coolguyzone left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good solution, thanks for the fix!

This branch was successfully deployed

2 active deployments
Preview – sentry-docs — faa267cc Deployed Oct 15, 2026 by vercel[bot]
Preview – develop-docs — faa267cc Deployed Oct 15, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: Normal Docs review has no urgent deadline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants