Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
2dccb66 to
ba2d764
Compare
ba2d764 to
de08c55
Compare
|
The plan checks platform-page traffic, client errors, and stack frames from the top nav and platform picker. An issue escalates when those stack frames appear or platform-page traffic falls. Services: Mention PlanWhat changedThe top nav SDKs item stays a plain link to platform docs. The unused SDK popup is gone. The sidebar platform picker still uses the remaining select control. This change is live after sentry-docs deploys. Catalog and the Vercel production deploy report both name sentry-docs. RiskPlatformSelector still serves the sidebar. A bad cleanup can stop platform switches on SDK pages. Concepts and Manage menus share this top-nav file and position hook. A hook mistake can hide those menus on every page. Intended effectThis cleanup adds no new metric. The popup never opened, so telemetry cannot show that it is gone. Use sampled platform-page traffic as the reachable proxy that the SDKs link and sidebar picker still reach platform docs. Absent looks like that share falling while all-page navigation holds. Traces are sampled at 30 percent. Compare sampled TPM, not raw users.
Regression watchA bad deploy can break the shared picker, the SDKs link, or sibling top-nav menus. Watch client error volume and stack frames in the changed files. Current top titles are mostly Algolia fetch noise and
If the specific stack frames rise, inspect TopNav Concepts and Manage menus and the sidebar picker on Not observableTelemetry cannot show that the popup is gone. No click event exists for the SDKs link. Error events use transaction Get Slack DMs about this change: cursor.com/automations/rollouts |
The top nav had a platform picker popup for "SDKs", but nothing ever opened it: its open state was only ever set to false and its trigger ref was never attached. "SDKs" has been a plain link since the nav redesign. Remove the popup and the PlatformSelector modes only it used (listOnly, alwaysOpen, dropdownStyle). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
de08c55 to
faa267c
Compare
coolguyzone
left a comment
There was a problem hiding this comment.
Good solution, thanks for the fix!
DESCRIBE YOUR PR
Stacked on #19928.
TopNavClientcontains a platform picker popup for "SDKs", but it can never open: its open state is only ever set tofalse, and the ref for its trigger button is never attached. "SDKs" has been a plain link since the nav redesign (#14178).This removes the popup and the
PlatformSelectormodes only it used (listOnly,alwaysOpen,dropdownStyle). No visible change.IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
Select exactly one option. For deadlines, replace
YYYY-MM-DDwith the due date. You can update this information later by editing the PR description.SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
🤖 Generated with Claude Code