Repository navigation
Bump API schema to {"messag - #19999
Hidden character warning
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Please update the IS YOUR CHANGE URGENT? section of the PR description:
This information helps the Docs team prioritize your review. |
|
The change rebuilds generated API reference pages from a new schema pin. The plan checks API page loads, API not-found counts, and production errors. An issue escalates when API page loads fall or API not-found counts rise. The new pin is not a git commit SHA, so those pages may fail to generate. Services: PlanWhat changedBuild now fetches OpenAPI from a new schema pin in resolveOpenAPI.ts. RiskAn invalid pin can throw during product-docs static generation. Intended effectGenerated API reference pages must keep loading from the new pin.
Regression watchA bad pin can drop generated API pages or break the product-docs build.
Not observableThe new schema text is not in telemetry, so added or changed endpoints cannot be confirmed. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4873c1a. Configure here.
| // SENTRY_API_SCHEMA_SHA is used in the sentry-docs GHA workflow in getsentry/sentry-api-schema. | ||
| // DO NOT change variable name unless you change it in the sentry-docs GHA workflow in getsentry/sentry-api-schema. | ||
| const SENTRY_API_SCHEMA_SHA = 'b342621e5125399429df4b22093675fd3259add9'; | ||
| const SENTRY_API_SCHEMA_SHA = '{"message":"API rate limit exceeded for 20.15.163.105. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)","documentation_url":"https://docs.github.com/rest/overview/resources-in-the-rest-api#rate-limiting"}'; |
There was a problem hiding this comment.
Invalid API schema SHA committed
High Severity
SENTRY_API_SCHEMA_SHA was set to a GitHub API rate-limit error payload instead of a commit SHA. The schema fetch URL is therefore invalid, and the unescaped apostrophe in the error text also breaks the string literal.
Reviewed by Cursor Bugbot for commit 4873c1a. Configure here.
|
Verified in
|
…ng (#20001) ## DESCRIBE YOUR PR The Bump API Schema SHA workflow got rate-limited by the GitHub API and wrote the error body (`{"message":"API rate limit exceeded for ..."}`) into `SENTRY_API_SCHEMA_SHA`. It then admin-merged the change ([#19999](#19999)). That broke `master` for about 10 minutes, until the next run ([#20000](#20000)) replaced it with a real SHA. The workflow called the commits API without authentication and never checked what came back. It now: - Sends the GitHub App token it already creates. That token has access to `sentry-api-schema`, so the request gets the much higher authenticated rate limit. - Uses `curl --fail`, so an HTTP error fails the job instead of returning the error body. - Fails the job unless the response is a 40-character hex SHA, so nothing else gets written into the file or merged. It also fixes `-sSl` to `-sSL`. Lowercase `-l` is curl's FTP `--list-only` flag; `-L` follows redirects, which is what was meant. ## IS YOUR CHANGE URGENT? - [x] No deadline: Not urgent, can wait up to 1 week+ ## PRE-MERGE CHECKLIST - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) <!-- junior-request-attribution:start --> via @sergical. <!-- junior-request-attribution:end --> <!-- junior-session-footer:start --> <!-- junior-conversation-id:slack%3AC8H0BQRDJ%3A1792070558.468179 --> -- [View Junior Session](https://junior-prod.sentry.dev/conversations/slack%3AC8H0BQRDJ%3A1792070558.468179) [[Sentry]](https://sentry.sentry.io/explore/conversations/slack%3AC8H0BQRDJ%3A1792070558.468179/?project=4510944073809921) <!-- junior-session-footer:end --> Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com> Co-authored-by: Sergiy Dybskiy <sergiy.dybskiy@sentry.io>


No description provided.