Skip to content

fix: avoid false temp path warning in enclave smoke - #10028

Merged
lpcox merged 1 commit into
mainfrom
lpcox-smoke-temp-warning-followup
Oct 15, 2026
Merged

lpcox merged 1 commit into
mainfrom
lpcox-smoke-temp-warning-followup

Conversation

@lpcox

@lpcox lpcox commented Oct 15, 2026

Copy link
Copy Markdown
Collaborator

What changed

The gh-aw v0.92.0 prompt validator scans every /tmp/ occurrence in workflow Markdown and permits only strings with the /tmp/gh-aw/ prefix. Its exact implementation is pkg/workflow/compiler_validators.go at b751436ce667ee01f7e4afb4472bd2c8c1f3897a, lines 67–69 and 108–138. The workflow's required audit-log environment value (/tmp/gh-aw/sandbox/firewall/audit/enclave.jsonl) already meets that prefix and remains unchanged. The warning came from explanatory collection-gap prose spelling /tmp/gh-aw without the trailing slash, not an unsafe agent temp-file instruction.

Reword only that phrase as “the framework-managed AWF temp root”; retain the substantive statement that the pinned action redacts that root and ${RUNNER_TEMP}/gh-aw, omits the early resolved-config path from the compiled artifact, and leaves failed-cleanup evidence incomplete. Update the test assertion accordingly. Regenerate with gh-aw v0.92.0 and run the required smoke postprocessor; only the affected lock's body hash changes.

Validation

  • Compile-only diagnostic command gh aw compile smoke-enclave-cloud-hypervisor --dry-run --allow-experimental --no-check-update --json: passed; the /tmp warning is gone. Shellcheck passed and model inventory was available. The one remaining notice is the experimental Cloud Hypervisor feature; it was explicitly accepted for this run. The report still states compile_only: true and execution_authorized: false. Optional actionlint, zizmor and poutine were not run.
  • Focused workflow/postprocessor tests: 3 suites, 60 tests passed; targeted Markdown lint and git diff --check passed.
  • A read-only security review of this three-file follow-up passed all ten checks; no confirmed vulnerabilities.

The required audit-log path and the documented AWF_RESOLVED_CONFIG collection gap are preserved. No dispatch, workflow execution, merge or Agent merge was performed. The user separately authorized one experimental workflow run after all prerequisites pass; that authorization is not exercised by this PR. Linux/KVM/live behavior and the original enclave-launch failure remain unverified.

SHA-256

File SHA-256
.github/workflows/smoke-enclave-cloud-hypervisor.md def31b61b7cb48a8fc614c0feb71356407dc3e4eef0d0c352e979ffdf66d8575
.github/workflows/smoke-enclave-cloud-hypervisor.lock.yml 45707aa3e1f0859aed5162175f3a09f77101ba3ec4eb1a5c65492943ff5a1e76

Authored Markdown overview

Source Change Security impact
workflow lines 183–186 Reword the temp-root name in explanatory prose. Preserves the redaction and collection-gap explanation; changes no execution behavior, credentials, artifact contents or isolation controls.

Reword the documented temp root so gh-aw v0.92.0's prompt-wide scan does not mistake explanatory prose for agent instructions. Preserve the required audit log path and resolved-config gap.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 4ce85139-2883-4f8c-9c6d-38ee8f5e6711
Copilot AI max review requested due to automatic review settings October 15, 2026 15:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Execution behavior is unchanged, and the remaining documentation clarification is non-blocking.

1 open finding
What changed in this PR

Removes a false temporary-path warning from the Cloud Hypervisor enclave smoke workflow without changing execution behavior.

Changes:

  • Rewords temp-root prose while preserving the collection-gap explanation.
  • Updates the matching test assertion and generated workflow body hash.
File Description
scripts/​ci/​smoke-enclave-workflow.test.ts Updates the prose assertion.
.github/​workflows/​smoke-enclave-cloud-hypervisor.md Rewords the temp-root reference.
.github/​workflows/​smoke-enclave-cloud-hypervisor.lock.yml Refreshes the body hash.

🧠 Review effort: Max


💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

redacts only `/tmp/gh-aw` and `${RUNNER_TEMP}/gh-aw`; the compiled artifact
upload includes the old audit tree, not the new early path. Neither consumer
uses `AWF_RESOLVED_CONFIG`, so evidence after failed cleanup remains incomplete.
redacts only the framework-managed AWF temp root and `${RUNNER_TEMP}/gh-aw`; the
@github-actions

Copy link
Copy Markdown
Contributor

✅ Coverage Check Passed

Overall Coverage

Metric Base PR Delta
Lines 93.18% 93.19% ➡️ +0.01%
Statements 91.76% 91.77% ➡️ +0.01%
Functions 90.67% 90.67% ➡️ +0.00%
Branches 85.62% 85.62% ➡️ +0.00%
📁 Per-file Coverage Changes (1 files)
File Lines (Before → After) Statements (Before → After)
src/log-directory-setup.ts 96.8% → 100.0% (+3.18%) 96.9% → 100.0% (+3.13%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

@lpcox
lpcox merged commit 97de8c4 into main Oct 15, 2026
29 checks passed
@lpcox
lpcox deleted the lpcox-smoke-temp-warning-followup branch October 15, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants