Repository navigation
fix: avoid false temp path warning in enclave smoke - #10028
Merged
Merged
Conversation
Reword the documented temp root so gh-aw v0.92.0's prompt-wide scan does not mistake explanatory prose for agent instructions. Preserve the required audit log path and resolved-config gap. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4ce85139-2883-4f8c-9c6d-38ee8f5e6711
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Execution behavior is unchanged, and the remaining documentation clarification is non-blocking.
1 open finding
What changed in this PR
Removes a false temporary-path warning from the Cloud Hypervisor enclave smoke workflow without changing execution behavior.
Changes:
- Rewords temp-root prose while preserving the collection-gap explanation.
- Updates the matching test assertion and generated workflow body hash.
| File | Description |
|---|---|
scripts/ci/smoke-enclave-workflow.test.ts |
Updates the prose assertion. |
.github/workflows/smoke-enclave-cloud-hypervisor.md |
Rewords the temp-root reference. |
.github/workflows/smoke-enclave-cloud-hypervisor.lock.yml |
Refreshes the body hash. |
🧠 Review effort: Max
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| redacts only `/tmp/gh-aw` and `${RUNNER_TEMP}/gh-aw`; the compiled artifact | ||
| upload includes the old audit tree, not the new early path. Neither consumer | ||
| uses `AWF_RESOLVED_CONFIG`, so evidence after failed cleanup remains incomplete. | ||
| redacts only the framework-managed AWF temp root and `${RUNNER_TEMP}/gh-aw`; the |
Contributor
✅ Coverage Check PassedOverall Coverage
📁 Per-file Coverage Changes (1 files)
Coverage comparison generated by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changed
The gh-aw v0.92.0 prompt validator scans every
/tmp/occurrence in workflow Markdown and permits only strings with the/tmp/gh-aw/prefix. Its exact implementation ispkg/workflow/compiler_validators.goatb751436ce667ee01f7e4afb4472bd2c8c1f3897a, lines 67–69 and 108–138. The workflow's required audit-log environment value (/tmp/gh-aw/sandbox/firewall/audit/enclave.jsonl) already meets that prefix and remains unchanged. The warning came from explanatory collection-gap prose spelling/tmp/gh-awwithout the trailing slash, not an unsafe agent temp-file instruction.Reword only that phrase as “the framework-managed AWF temp root”; retain the substantive statement that the pinned action redacts that root and
${RUNNER_TEMP}/gh-aw, omits the early resolved-config path from the compiled artifact, and leaves failed-cleanup evidence incomplete. Update the test assertion accordingly. Regenerate with gh-aw v0.92.0 and run the required smoke postprocessor; only the affected lock's body hash changes.Validation
gh aw compile smoke-enclave-cloud-hypervisor --dry-run --allow-experimental --no-check-update --json: passed; the/tmpwarning is gone. Shellcheck passed and model inventory was available. The one remaining notice is the experimental Cloud Hypervisor feature; it was explicitly accepted for this run. The report still statescompile_only: trueandexecution_authorized: false. Optional actionlint, zizmor and poutine were not run.git diff --checkpassed.The required audit-log path and the documented
AWF_RESOLVED_CONFIGcollection gap are preserved. No dispatch, workflow execution, merge or Agent merge was performed. The user separately authorized one experimental workflow run after all prerequisites pass; that authorization is not exercised by this PR. Linux/KVM/live behavior and the original enclave-launch failure remain unverified.SHA-256
.github/workflows/smoke-enclave-cloud-hypervisor.mddef31b61b7cb48a8fc614c0feb71356407dc3e4eef0d0c352e979ffdf66d8575.github/workflows/smoke-enclave-cloud-hypervisor.lock.yml45707aa3e1f0859aed5162175f3a09f77101ba3ec4eb1a5c65492943ff5a1e76Authored Markdown overview