Share JSON-object validation helper by Copilot · Pull Request #10062 · github/gh-aw-firewall

Copilot · 2026-10-16T03:28:19Z

Duplicate requireObject guards in manifest and NVX persistence parsers could drift, including their validation error messages.

Refactoring
- Added shared src/json-validation.ts helper.
- Reused it across Cloud Hypervisor artifact, enclave artifact, and NVX outcome parsers.
Coverage
- Added tests for valid objects and rejected JSON values.

export function requireObject(
  value: unknown,
  label: string,
): Record<string, unknown> {
  if (!value || typeof value !== 'object' || Array.isArray(value)) {
    throw new Error(`${label} must be a JSON object`);
  }
  return value as Record<string, unknown>;
}

Fixes [Duplicate Code] Shared JSON-object validation helper #10040

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

Copilot

🟢 Approval recommended

The extraction preserves all three guards’ behavior, and the remaining suggestions are optional.

1 open finding

Add tests for truthy primitive values accepted by the shared helper · New

What changed in this PR

Centralizes JSON-object validation across manifest and NVX persistence parsers, addressing #10040 without changing validation behavior or error messages.

Changes:

Extracts requireObject and replaces three local copies.
Adds focused tests for accepted objects and rejected values.

File	Description
src/nvx/outcome.ts	Uses the shared validator.
src/json-validation.ts	Defines the shared object guard.
src/json-validation.test.ts	Tests accepted and rejected inputs.
src/cloud-hypervisor/enclave-artifact-manifest.ts	Replaces its local guard with an import.
src/cloud-hypervisor/artifact-manifest.ts	Replaces its local guard with an import.

🧠 Review effort: Max

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

github-actions · 2026-10-16T04:29:29Z

✅ Copilot review passed with no inline comments.

@copilot Add the ready-for-aw label to this PR to trigger agentic CI smoke tests.

github-actions · 2026-10-16T04:35:34Z

⚠️ Coverage Regression Detected

This PR decreases test coverage. Please add tests to maintain coverage levels.

Overall Coverage

Metric	Base	PR	Delta
Lines	93.18%	93.20%	📈 +0.02%
Statements	91.76%	91.78%	📈 +0.02%
Functions	90.68%	90.67%	📉 -0.01%
Branches	85.62%	85.64%	📈 +0.02%

📁 Per-file Coverage Changes (4 files)

File	Lines (Before → After)	Statements (Before → After)
`src/nvx/one-shot-adapter.ts`	82.9% → 83.4% (+0.56%)	80.2% → 80.7% (+0.52%)
`src/cloud-hypervisor/artifact-manifest.ts`	87.3% → 88.5% (+1.22%)	87.3% → 88.5% (+1.22%)
`src/nvx/outcome.ts`	84.0% → 85.4% (+1.41%)	84.3% → 85.7% (+1.40%)
`src/log-directory-setup.ts`	96.8% → 100.0% (+3.18%)	96.9% → 100.0% (+3.13%)

✨ New Files (1 files)

src/json-validation.ts: 100.0% lines

Coverage comparison generated by scripts/ci/compare-coverage.ts

github-actions · 2026-10-16T04:37:16Z

🛡️ Smoke Copilot Network Isolation confirmed the egress allowlist is enforced. ✅

🛡️ Egress verdict from Smoke Copilot Network Isolation

github-actions · 2026-10-16T04:37:17Z

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

🔮 The oracle has spoken through Smoke Codex

github-actions · 2026-10-16T04:37:21Z

🔌 Smoke Services — All services reachable! ✅

🔌 Service connectivity validated by Smoke Services

github-actions · 2026-10-16T04:37:22Z

Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded.

Tested by Smoke Chroot

github-actions · 2026-10-16T04:37:23Z

🪪 Smoke Copilot BYOK AOAI (Entra) is testing Azure OpenAI BYOK (Entra / GitHub OIDC) mode on this pull request...

github-actions · 2026-10-16T04:37:24Z

🚀 Security Guard has started processing this pull request

github-actions · 2026-10-16T04:37:25Z

✅ Smoke Claude passed

Generated by Smoke Claude for #10062

github-actions · 2026-10-16T04:37:26Z

Smoke Cloud Hypervisor reports failed. Cloud Hypervisor + Copilot failed.

Cloud Hypervisor + Copilot smoke test by Smoke Cloud Hypervisor

github-actions · 2026-10-16T04:37:28Z

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

📰 BREAKING: Report filed by Smoke Copilot

github-actions · 2026-10-16T04:37:30Z

📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅

📡 OTel tracing validated by Smoke OTel Tracing

github-actions · 2026-10-16T04:37:30Z

🔑 Smoke Copilot BYOK AOAI (api-key) is testing Azure OpenAI BYOK (api-key) mode on this pull request...

github-actions · 2026-10-16T04:37:31Z

✅ Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓

🔑 BYOK report filed by Smoke Copilot BYOK

github-actions · 2026-10-16T04:37:40Z

✅ Build Test Suite completed successfully!

Generated by Build Test Suite for #10062

github-actions · 2026-10-16T04:38:05Z

💎 Smoke Gemini is crystallizing results on this pull request...

github-actions · 2026-10-16T04:47:16Z

Services smoke test: ✅ Redis PONG, ✅ pg_isready accepting connections, ✅ SELECT 1 = 1. PASS

🔌 Service connectivity validated by Smoke Services
_{Add label ready-for-aw to run again}

github-actions · 2026-10-16T04:47:18Z

EGRESS_RESULT allow=pass deny=pass

✅ Allowed domain (api.github.com → 200)
✅ Blocked domain (example.com blocked)

Overall: PASS — @Copilot

🛡️ Egress verdict from Smoke Copilot Network Isolation
_{Add label ready-for-aw to run again}

github-actions · 2026-10-16T04:47:31Z

Smoke Copilot — PR "Share JSON-object validation helper"

✅ GitHub MCP (latest merged: chore(deps): bump the all-github-actions group with 3 updates #10067 "chore(deps): bump the all-github-actions group with 3 updates")
✅ github.com connectivity (HTTP 200)
✅ File write/read

Overall: PASS — cc @Copilot (author), assignees @lpcox @Copilot

📰 BREAKING: Report filed by Smoke Copilot
_{Add label ready-for-aw to run again}

github-actions · 2026-10-16T04:47:46Z

✅ smoke-copilot-byok

✅ GitHub MCP connectivity
✅ HTTP 200 to github.com
✅ File write/read test
✅ Direct BYOK inference (COPILOT_PROVIDER_API_KEY → api-proxy → api.githubcopilot.com)

Status: PASS — Running in direct BYOK mode via api-proxy sidecar.

🔑 BYOK report filed by Smoke Copilot BYOK
_{Add label ready-for-aw to run again}

github-actions · 2026-10-16T04:47:58Z

Smoke Test: Claude Engine Validation

Check	Status
API	✅ PASS
gh CLI	✅ PASS
File	✅ PASS

Overall result: PASS

Generated by Smoke Claude for #10062 · claude · haiku45 · 24.1 AIC · ⊞ 6.1K · ◷
_{Add label ready-for-aw to run again}

github-actions · 2026-10-16T04:48:10Z

OTEL smoke test

✅ S1 Module: otel.js loads; exports startRequestSpan, setTokenAttributes, setBudgetAttributes, endSpan, endSpanError, shutdown, isEnabled (+ exporter internals)
✅ S2 Tests: 3 OTEL suites, 68/68 passed
✅ S3 Env forwarding: OTEL/trace vars found in env-passthrough.ts and api-proxy-env-config.ts
✅ S4 Token tracker: onUsage hook present in token-tracker-http.js
⚠️ S5 Diagnostics: no exported-span data checked (I re-ran the checks locally); no unexpected failures

📡 OTel tracing validated by Smoke OTel Tracing
_{Add label ready-for-aw to run again}

github-actions · 2026-10-16T04:48:52Z

Smoke Test

feat: correlate enclave handoff and VMM launch diagnostics ✅
Extract shared private cleanup-file writer ✅
GitHub PR read ✅
Playwright title check ❌
Temp file write/read ✅
Build (npm ci && npm run build) ✅
Overall: FAIL

🔮 The oracle has spoken through Smoke Codex
_{Add label ready-for-aw to run again}

github-actions · 2026-10-16T04:49:07Z

Chroot Version Comparison

Runtime	Host Version	Chroot Version	Match?
Python	Python 3.12.15	Python 3.12.15	✅ YES
Node.js	v24.21.0	v22.23.2	❌ NO
Go	go1.22.12	go1.22.12	✅ YES

Not all tests passed (Node.js version mismatch), so the smoke-chroot label was not added.

Tested by Smoke Chroot
_{Add label ready-for-aw to run again}

github-actions · 2026-10-16T04:50:01Z

🏗️ Build Test Suite Results

Ecosystem	Project	Build/Install	Tests	Status
Bun	elysia	✅	1/1 passed	✅ PASS
Bun	hono	✅	1/1 passed	✅ PASS
C++	fmt	✅	N/A	✅ PASS
C++	json	✅	N/A	✅ PASS
Deno	oak	N/A	1/1 passed	✅ PASS
Deno	std	N/A	1/1 passed	✅ PASS
.NET	hello-world	✅	N/A	✅ PASS
.NET	json-parse	✅	N/A	✅ PASS
Go	color	✅	ok	✅ PASS
Go	env	✅	ok	✅ PASS
Go	uuid	✅	ok	✅ PASS
Java	gson	✅	1/1 passed	✅ PASS
Java	caffeine	✅	1/1 passed	✅ PASS
Node.js	clsx	✅	passed	✅ PASS
Node.js	execa	✅	passed	✅ PASS
Node.js	p-limit	✅	passed	✅ PASS
Rust	fd	✅	1/1 passed	✅ PASS
Rust	zoxide	✅	1/1 passed	✅ PASS

Overall: 8/8 ecosystems passed — PASS

Notes: the Bun/Deno install scripts and the default ~/.m2/dotnet home were blocked by the sandbox, so Bun and Deno were installed via npm, and .NET/Maven used workspace-local cache dirs under /tmp/gh-aw/agent.

Generated by Build Test Suite for #10062 · copilot · auto · 23.3 AIC · ⊞ 12K · ◷
_{Add label ready-for-aw to run again}

Initial plan

9425a83

Copilot AI assigned Copilot and lpcox Oct 16, 2026

Copilot AI linked an issue Oct 16, 2026 that may be closed by this pull request

[Duplicate Code] Shared JSON-object validation helper #10040

Closed

Copilot started work on behalf of lpcox October 16, 2026 03:28

View session

refactor: share JSON object validation helper

259cc32

Co-authored-by: lpcox <15877973+lpcox@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Refactor shared JSON-object validation helper~~ Share JSON-object validation helper Oct 16, 2026

Copilot finished work on behalf of lpcox October 16, 2026 03:32

Copilot AI requested a review from lpcox October 16, 2026 03:32

lpcox marked this pull request as ready for review October 16, 2026 03:34

Copilot AI max review requested due to automatic review settings October 16, 2026 03:34

Copilot started reviewing on behalf of lpcox October 16, 2026 03:34

View session

Copilot AI reviewed Oct 16, 2026

View reviewed changes

Comment thread src/json-validation.test.ts Outdated

Update test cases for requireObject function

20411e3

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

lpcox added the ready-for-aw label Oct 16, 2026

lpcox enabled auto-merge (squash) October 16, 2026 04:36

lpcox had a problem deploying to aoai-model October 16, 2026 04:37 — with GitHub Actions Failure

github-actions Bot added the smoke-cloud-hypervisor label Oct 16, 2026

github-actions Bot mentioned this pull request Oct 16, 2026

[aw] Smoke Cloud Hypervisor failed #10070

Closed

github-actions Bot added smoke-copilot-network-isolation Copilot network-isolation egress smoke test smoke-services labels Oct 16, 2026

github-actions Bot added the smoke-copilot label Oct 16, 2026

github-actions Bot added the smoke-copilot-byok label Oct 16, 2026

lpcox deployed to aoai-model October 16, 2026 04:47 — with GitHub Actions Active

github-actions Bot added the smoke-claude label Oct 16, 2026

lpcox had a problem deploying to aoai-model October 16, 2026 04:48 — with GitHub Actions Failure

github-actions Bot added the build-test label Oct 16, 2026

lpcox merged commit 92be3a9 into main Oct 16, 2026
145 of 154 checks passed

lpcox deleted the copilot/fix-duplicate-json-object-validation branch October 16, 2026 04:56

Conversation

Copilot AI commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

Uh oh!

github-actions Bot commented Oct 16, 2026

Uh oh!

github-actions Bot commented Oct 16, 2026

⚠️ Coverage Regression Detected

Overall Coverage

Uh oh!

github-actions Bot commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 16, 2026

Uh oh!

github-actions Bot commented Oct 16, 2026

Uh oh!

github-actions Bot commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 16, 2026

Uh oh!

github-actions Bot commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 16, 2026

Uh oh!

github-actions Bot commented Oct 16, 2026

Uh oh!

github-actions Bot commented Oct 16, 2026

Uh oh!

github-actions Bot commented Oct 16, 2026

Uh oh!

github-actions Bot commented Oct 16, 2026

Uh oh!

github-actions Bot commented Oct 16, 2026

Smoke Test: Claude Engine Validation

Uh oh!

github-actions Bot commented Oct 16, 2026

Uh oh!

github-actions Bot commented Oct 16, 2026

Smoke Test

Uh oh!

github-actions Bot commented Oct 16, 2026

Chroot Version Comparison

Uh oh!

github-actions Bot commented Oct 16, 2026

🏗️ Build Test Suite Results

Uh oh!

Uh oh!

This branch had an error being deployed

Reviewers

Assignees

Labels

Copilot AI commented Oct 16, 2026 •

edited

Loading

github-actions Bot commented Oct 16, 2026 •

edited

Loading

github-actions Bot commented Oct 16, 2026 •

edited

Loading

github-actions Bot commented Oct 16, 2026 •

edited

Loading

github-actions Bot commented Oct 16, 2026 •

edited

Loading

github-actions Bot commented Oct 16, 2026 •

edited

Loading

github-actions Bot commented Oct 16, 2026 •

edited

Loading

github-actions Bot commented Oct 16, 2026 •

edited

Loading

github-actions Bot commented Oct 16, 2026 •

edited

Loading

github-actions Bot commented Oct 16, 2026 •

edited

Loading

github-actions Bot commented Oct 16, 2026 •

edited

Loading