Sanitize Cloud Hypervisor smoke harness failure output by Copilot · Pull Request #10123 · github/gh-aw-firewall

Copilot · 2026-10-16T17:56:33Z

The live smoke harness printed raw rejection messages, allowing sensitive data to reach console output (CodeQL alert 1142). This change replaces that path with a bounded diagnostic while preserving nonzero failure status.

Failure reporting: Route main() rejections through a handler that does not inspect the rejection value:

function reportFailure(_error) {
  console.error('Live enclave acceptance failed; raw error details were suppressed. '
    + 'Review any AWF_HOST_STARTUP_DIAGNOSTIC records above.');
  process.exitCode = 1;
}

Regression coverage: Verify sentinel content stays out of output for Error messages, nested causes, plain objects, and string rejections.

Fixes fix: resolve clear-text logging finding in Cloud Hypervisor enclave smoke harness #10121

Copilot

🟡 Changes recommended

Failures without startup diagnostic records still need actionable, non-sensitive context.

1 open finding

Preserve actionable diagnostics for missing-token startup failures · New

What changed in this PR

Updates AWF’s Cloud Hypervisor live smoke harness to suppress sensitive rejection details.

Changes:

Replaces raw error logging with fixed output while preserving failure status.
Adds sentinel-based regression coverage for four rejection variants.

File	Description
`scripts/ci/cloud-hypervisor-enclave-live-smoke.test.ts`	Tests output suppression and failure status.
`scripts/ci/cloud-hypervisor-enclave-live-smoke.js`	Adds and connects the sanitized failure handler.

🧠 Review effort: Max

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

+    'Live enclave acceptance failed; raw error details were suppressed. '
+    + 'Review any AWF_HOST_STARTUP_DIAGNOSTIC records above.',


lpcox · 2026-10-16T18:30:08Z

@copilot address review feedback

Copilot · 2026-10-16T18:36:07Z

@copilot address review feedback

Added allowlisted stage labels for each credential prerequisite and the later acceptance phases, with an unknown stage fallback; raw rejection values remain suppressed. Regression tests pass (173 tests). Commit: a3b6725.

github-actions · 2026-10-16T18:54:14Z

✅ Copilot review passed with no inline comments.

@copilot Add the ready-for-aw label to this PR to trigger agentic CI smoke tests.

github-actions · 2026-10-16T18:59:29Z

✅ Coverage Check Passed

Overall Coverage

Metric	Base	PR	Delta
Lines	93.46%	93.47%	📈 +0.01%
Statements	92.08%	92.09%	📈 +0.01%
Functions	90.91%	90.91%	➡️ +0.00%
Branches	86.06%	86.06%	➡️ +0.00%

📁 Per-file Coverage Changes (1 files)

File	Lines (Before → After)	Statements (Before → After)
`src/log-directory-setup.ts`	96.8% → 100.0% (+3.18%)	96.9% → 100.0% (+3.13%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

github-actions · 2026-10-16T19:18:44Z

✅ Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓

🔑 BYOK report filed by Smoke Copilot BYOK

github-actions · 2026-10-16T19:18:46Z

🛡️ Smoke Copilot Network Isolation confirmed the egress allowlist is enforced. ✅

🛡️ Egress verdict from Smoke Copilot Network Isolation

github-actions · 2026-10-16T19:18:46Z

🚀 Security Guard has started processing this pull request

github-actions · 2026-10-16T19:18:47Z

🔌 Smoke Services — All services reachable! ✅

🔌 Service connectivity validated by Smoke Services

github-actions · 2026-10-16T19:18:47Z

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

📰 BREAKING: Report filed by Smoke Copilot

github-actions · 2026-10-16T19:18:47Z

Smoke Cloud Hypervisor completed. Cloud Hypervisor + Copilot passed.

Cloud Hypervisor + Copilot smoke test by Smoke Cloud Hypervisor

github-actions · 2026-10-16T19:18:48Z

📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅

📡 OTel tracing validated by Smoke OTel Tracing

github-actions · 2026-10-16T19:18:49Z

🔑 Smoke Copilot BYOK AOAI (api-key) is testing Azure OpenAI BYOK (api-key) mode on this pull request...

github-actions · 2026-10-16T19:18:50Z

💎 Smoke Gemini is crystallizing results on this pull request...

github-actions · 2026-10-16T19:18:50Z

✅ Smoke Claude passed

Generated by Smoke Claude for #10123

github-actions · 2026-10-16T19:18:53Z

✅ Build Test Suite completed successfully!

Generated by Build Test Suite for #10123

github-actions · 2026-10-16T19:18:53Z

Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded.

Tested by Smoke Chroot

github-actions · 2026-10-16T19:18:55Z

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

🔮 The oracle has spoken through Smoke Codex

github-actions · 2026-10-16T19:19:04Z

🪪 Smoke Copilot BYOK AOAI (Entra) is testing Azure OpenAI BYOK (Entra / GitHub OIDC) mode on this pull request...

github-actions · 2026-10-16T19:28:19Z

Cloud Hypervisor + Copilot smoke test

Merged PR lookup: PASS
github.com connectivity: PASS (HTTP 200)
File write/read: PASS
example.com blocked: PASS (HTTP 000)
Overall: PASS

Cloud Hypervisor + Copilot smoke test by Smoke Cloud Hypervisor
_{Add label ready-for-aw to run again}

github-actions · 2026-10-16T19:28:57Z

EGRESS_RESULT allow=pass deny=pass

✅ Allowed domain (api.github.com → 200)
✅ Blocked domain (example.com blocked; curl failed with a self-signed certificate error, so it never reached the real site)

Overall: PASS. cc @lpcox

🛡️ Egress verdict from Smoke Copilot Network Isolation
_{Add label ready-for-aw to run again}

github-actions · 2026-10-16T19:28:59Z

Smoke Test: Copilot BYOK (Direct) Mode ✅

Test Results:

✅ GitHub MCP: 2 recent merged PRs verified
✅ github.com connectivity: HTTP 200
✅ File write/read: Test file created and readable
✅ BYOK inference: Running via api-proxy → api.githubcopilot.com

Status: PASS | Mode: Direct BYOK (COPILOT_PROVIDER_API_KEY)

🔑 BYOK report filed by Smoke Copilot BYOK
_{Add label ready-for-aw to run again}

github-actions · 2026-10-16T19:29:04Z

Smoke Copilot

✅ GitHub MCP: chore: pin enclave smoke to AWF v0.28.61 #10125 "chore: pin enclave smoke to AWF v0.28.61"
✅ github.com connectivity (HTTP 200)
✅ File write/read

Overall: PASS — @lpcox

📰 BREAKING: Report filed by Smoke Copilot
_{Add label ready-for-aw to run again}

github-actions · 2026-10-16T19:29:08Z

Services smoke test: ✅ Redis PONG, ✅ pg_isready, ✅ SELECT 1. Overall: PASS

🔌 Service connectivity validated by Smoke Services
_{Add label ready-for-aw to run again}

github-actions · 2026-10-16T19:29:10Z

Smoke Test: Claude Engine Validation

Check	Status
API	✅ PASS
GitHub CLI	✅ PASS
File	✅ PASS

Overall result: PASS

Generated by Smoke Claude for #10123 · claude · haiku45 · 49 AIC · ⊞ 6.1K · ◷
_{Add label ready-for-aw to run again}

github-actions · 2026-10-16T19:29:44Z

OTEL smoke test

✅ S1 Module loading: otel.js exports startRequestSpan, setTokenAttributes, setBudgetAttributes, endSpan, endSpanError, shutdown, isEnabled
✅ S2 Tests: 68/68 passed (3 suites)
✅ S3 Env forwarding: trace context in env-passthrough.ts; OTEL vars in api-proxy-env-config.ts
✅ S4 Token tracker: onUsage hook present in token-tracker-http.js
✅ S5 Diagnostics: /tmp/gh-aw/otel.jsonl present (1 entry)

📡 OTel tracing validated by Smoke OTel Tracing
_{Add label ready-for-aw to run again}

github-actions · 2026-10-16T19:30:17Z

Chroot version comparison

Runtime	Host Version	Chroot Version	Match?
Python	Python 3.12.15	Python 3.12.15	✅
Node.js	v24.21.0	v2.98.0	❌
Go	go1.22.12	go1.22.12	✅

Node.js doesn't match. The chroot reported v2.98.0, which doesn't look like a Node version. The smoke-chroot label was not added.

Tested by Smoke Chroot
_{Add label ready-for-aw to run again}

github-actions · 2026-10-16T19:30:51Z

🏗️ Build Test Suite Results

Ecosystem	Project	Build/Install	Tests	Status
Bun	elysia	✅	1/1 passed	✅ PASS
Bun	hono	✅	1/1 passed	✅ PASS
C++	fmt	✅	N/A	✅ PASS
C++	json	✅	N/A	✅ PASS
Deno	oak	N/A	1/1 passed	✅ PASS
Deno	std	N/A	1/1 passed	✅ PASS
.NET	hello-world	✅	N/A	✅ PASS
.NET	json-parse	✅	N/A	✅ PASS
Go	color	✅	all passed	✅ PASS
Go	env	✅	all passed	✅ PASS
Go	uuid	✅	all passed	✅ PASS
Java	gson	✅	1/1 passed	✅ PASS
Java	caffeine	✅	1/1 passed	✅ PASS
Node.js	clsx	✅	all passed	✅ PASS
Node.js	execa	✅	all passed	✅ PASS
Node.js	p-limit	✅	all passed	✅ PASS
Rust	fd	✅	1/1 passed	✅ PASS
Rust	zoxide	✅	1/1 passed	✅ PASS

Overall: 8/8 ecosystems passed — PASS

Notes: the Bun/Deno install scripts were blocked by sandbox permissions, so Bun and Deno were installed via npm instead. The .NET and Maven runs needed writable cache and runtime dirs under /tmp/gh-aw/agent. Default locations failed, but the runs passed once the dirs were changed.

Generated by Build Test Suite for #10123 · copilot · auto · 24.9 AIC · ⊞ 12K · ◷
_{Add label ready-for-aw to run again}

github-actions · 2026-10-16T19:31:01Z

chore: pin enclave smoke to AWF v0.28.61 — ✅
Fix capability-file race in enclave executor test — ✅
PR detail lookup — ✅
Playwright title check — ❌
Temp file write/read — ✅
Build npm ci && npm run build — ✅
Overall status: FAIL

🔮 The oracle has spoken through Smoke Codex
_{Add label ready-for-aw to run again}

Initial plan

326dc6b

Copilot AI assigned Copilot and lpcox Oct 16, 2026

Copilot started work on behalf of lpcox October 16, 2026 17:57

View session

Copilot AI linked an issue Oct 16, 2026 that may be closed by this pull request

fix: resolve clear-text logging finding in Cloud Hypervisor enclave smoke harness #10121

Closed

fix: sanitize enclave smoke harness failures

6c791d5

Copilot AI changed the title ~~[WIP] Fix clear-text logging in Cloud Hypervisor enclave smoke harness~~ Sanitize Cloud Hypervisor smoke harness failure output Oct 16, 2026

Copilot finished work on behalf of lpcox October 16, 2026 18:04

Copilot AI requested a review from lpcox October 16, 2026 18:04

lpcox marked this pull request as ready for review October 16, 2026 18:05

Copilot AI max review requested due to automatic review settings October 16, 2026 18:05

Copilot started reviewing on behalf of lpcox October 16, 2026 18:06

View session

Copilot AI reviewed Oct 16, 2026

View reviewed changes

Comment thread scripts/ci/cloud-hypervisor-enclave-live-smoke.js Outdated

Comment on lines +1748 to +1749

'Live enclave acceptance failed; raw error details were suppressed. '

+ 'Review any AWF_HOST_STARTUP_DIAGNOSTIC records above.',

Copilot started work on behalf of lpcox October 16, 2026 18:30

View session

fix: add sanitized smoke failure stages

a3b6725

Copilot finished work on behalf of lpcox October 16, 2026 18:36

lpcox added the ready-for-aw label Oct 16, 2026

lpcox enabled auto-merge (squash) October 16, 2026 19:18

lpcox had a problem deploying to aoai-model October 16, 2026 19:19 — with GitHub Actions Failure

github-actions Bot added smoke-cloud-hypervisor smoke-copilot-network-isolation Copilot network-isolation egress smoke test labels Oct 16, 2026

github-actions Bot added the smoke-copilot-byok label Oct 16, 2026

github-actions Bot added the smoke-copilot label Oct 16, 2026

github-actions Bot added the smoke-services label Oct 16, 2026

github-actions Bot added the smoke-claude label Oct 16, 2026

lpcox deployed to aoai-model October 16, 2026 19:30 — with GitHub Actions Active

lpcox had a problem deploying to aoai-model October 16, 2026 19:30 — with GitHub Actions Failure

github-actions Bot added the build-test label Oct 16, 2026

github-actions Bot added the smoke-codex label Oct 16, 2026

lpcox merged commit 2bbcc9e into main Oct 16, 2026
137 of 144 checks passed

lpcox deleted the copilot/fix-clear-text-logging branch October 16, 2026 19:38

		'Live enclave acceptance failed; raw error details were suppressed. '
		+ 'Review any AWF_HOST_STARTUP_DIAGNOSTIC records above.',

Conversation

Copilot AI commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

lpcox commented Oct 16, 2026

Uh oh!

Copilot AI commented Oct 16, 2026

Uh oh!

github-actions Bot commented Oct 16, 2026

Uh oh!

github-actions Bot commented Oct 16, 2026

✅ Coverage Check Passed

Overall Coverage

Uh oh!

github-actions Bot commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 16, 2026

Uh oh!

github-actions Bot commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 16, 2026

Uh oh!

github-actions Bot commented Oct 16, 2026

Uh oh!

github-actions Bot commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 16, 2026

Uh oh!

github-actions Bot commented Oct 16, 2026

Uh oh!

github-actions Bot commented Oct 16, 2026

Uh oh!

github-actions Bot commented Oct 16, 2026

Smoke Test: Copilot BYOK (Direct) Mode ✅

Uh oh!

github-actions Bot commented Oct 16, 2026

Uh oh!

github-actions Bot commented Oct 16, 2026

Uh oh!

github-actions Bot commented Oct 16, 2026

Smoke Test: Claude Engine Validation

Uh oh!

github-actions Bot commented Oct 16, 2026

Uh oh!

github-actions Bot commented Oct 16, 2026

Chroot version comparison

Uh oh!

github-actions Bot commented Oct 16, 2026

🏗️ Build Test Suite Results

Uh oh!

github-actions Bot commented Oct 16, 2026

Uh oh!

Copilot AI commented Oct 16, 2026 •

edited

Loading

github-actions Bot commented Oct 16, 2026 •

edited

Loading

github-actions Bot commented Oct 16, 2026 •

edited

Loading

github-actions Bot commented Oct 16, 2026 •

edited

Loading

github-actions Bot commented Oct 16, 2026 •

edited

Loading

github-actions Bot commented Oct 16, 2026 •

edited

Loading

github-actions Bot commented Oct 16, 2026 •

edited

Loading

github-actions Bot commented Oct 16, 2026 •

edited

Loading

github-actions Bot commented Oct 16, 2026 •

edited

Loading

github-actions Bot commented Oct 16, 2026 •

edited

Loading

github-actions Bot commented Oct 16, 2026 •

edited

Loading