fix: preserve durable KVM runner ACL by lpcox · Pull Request #9992 · github/gh-aw-firewall

lpcox · 2026-10-14T22:31:42Z

Summary

retain the first validated ACL baseline for every Cloud Hypervisor device after launch-time ACL intent completion
compose durable non-VMM named users with the fresh deletion baseline under the existing shared ACL lock
preserve exact mask semantics and live peer VMM entries while removing only the target VMM ACE
add deterministic regressions for normal sequential cleanup, concurrent cleanup in both orders, cancellation recovery, stale recovery, partial intent release, persistence retry, and exact ACL validation

Root cause

Merged #9987 made accessed device paths durable but intentionally released the grant-time ACL baseline after launch restoration. Normal and stale account-deletion cleanup then journaled only a fresh baseline. If that fresh observation contained the hosted-runner mask residue but had already lost the durable UID 1001 runner ACE, cleanup treated the degraded ACL as authoritative and restored it before and after deleting the UID 999 VMM account. That consistently produced the observed mask-only hash while all other cleanup evidence completed.

The fix keeps the first validated per-device baseline separately from active cleanup intent. Fresh deletion baselines remain authoritative for current owner/group/other entries and live peer VMM composition, but durable historical non-VMM user ACEs are a restoration floor. Mask permissions are merged so the retained ACE keeps its original effective access without weakening the existing lock, identity validation, crash-safe persistence, or unowned-ACE rejection.

Validation

focused ACL lifecycle suite: 119 passed
npm run build
npm run type-check
npm run lint (0 errors; repository baseline warnings only)
npm run lint:md
full unit suite: 463 suites passed, 8,276 tests passed; 4 suites / 33 tests skipped
full coverage: 463 suites passed, 8,276 tests passed; statements 91.15%, branches 85.21%, functions 89.77%, lines 92.53%

The first coverage invocation encountered one unrelated 5-second timeout in scripts/ci/gh-cli-proxy-wrapper.test.ts; the test passed immediately in isolation and the complete coverage suite then passed.

No retry or resume of run 38644795166 was performed, and no pilot-100, pilot-1000, or benchmark campaign was dispatched.

Retain the first validated device ACL baseline after launch intent completion. Compose its non-VMM entries with fresh deletion baselines during normal and stale cleanup. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7b641e35-ee0f-404f-b119-2dd2ebe950fa

github-actions · 2026-10-14T22:32:20Z

Documentation Preview

Documentation has been built for this PR.

Download preview artifact

To view locally:

Download the docs-preview-pr-9992 artifact from the workflow run
Unzip and open index.html in your browser

Built from commit cb58f2f

github-actions · 2026-10-14T22:37:45Z

✅ Coverage Check Passed

Overall Coverage

Metric	Base	PR	Delta
Lines	93.32%	93.31%	➡️ -0.01%
Statements	91.91%	91.91%	➡️ +0.00%
Functions	90.64%	90.64%	➡️ +0.00%
Branches	85.67%	85.67%	➡️ +0.00%

📁 Per-file Coverage Changes (6 files)

File	Lines (Before → After)	Statements (Before → After)
`src/cloud-hypervisor/device-acl.ts`	100.0% → 98.8% (-1.25%)	100.0% → 98.9% (-1.12%)
`src/cloud-hypervisor/cleanup-vmm-identity.ts`	84.1% → 83.3% (-0.78%)	84.3% → 83.6% (-0.74%)
`src/cloud-hypervisor/vmm-identity.ts`	97.7% → 97.1% (-0.58%)	95.2% → 94.7% (-0.47%)
`src/cloud-hypervisor/cleanup-identity.ts`	92.4% → 92.0% (-0.39%)	92.6% → 92.2% (-0.40%)
`src/cloud-hypervisor/cleanup-handle.ts`	94.5% → 94.7% (+0.20%)	91.3% → 91.6% (+0.29%)
`src/log-directory-setup.ts`	96.8% → 100.0% (+3.18%)	96.9% → 100.0% (+3.13%)

Coverage comparison generated by scripts/ci/compare-coverage.ts

Copilot

🟡 Changes recommended

ACL mask composition can permanently broaden device permissions after temporary VMM access is revoked.

1 open finding

ACL mask widens or revokes permissions during VMM cleanup · New

What changed in this PR

This PR preserves Cloud Hypervisor device ACL history so normal and stale VMM cleanup can restore durable runner access.

Changes:

Retain initial device baselines after launch cleanup completes.
Compose historical user entries with fresh deletion baselines.
Extend lifecycle regressions and document ACL retention.

File	Description
src/cloud-hypervisor/vmm-identity.ts	Retains and uses initial ACL history.
src/cloud-hypervisor/vmm-identity.test.ts	Updates normal and concurrent cleanup regressions.
src/cloud-hypervisor/device-acl.ts	Combines historical users and ACL masks.
src/cloud-hypervisor/device-acl.test.ts	Tests historical runner-access restoration.
src/cloud-hypervisor/cleanup-vmm-identity.ts	Uses retained history during recovery.
src/cloud-hypervisor/cleanup-vmm-identity.test.ts	Updates recovery and persistence-retry cases.
src/cloud-hypervisor/cleanup-registry.test.ts	Tests runner-access restoration during stale recovery.
src/cloud-hypervisor/cleanup-identity.ts	Defines and validates retained history fields.
src/cloud-hypervisor/cleanup-identity.test.ts	Tests malformed history rejection.
src/cloud-hypervisor/cleanup-handle.ts	Persists initial device ACL history.
src/cloud-hypervisor/cleanup-handle.test.ts	Checks history survives intent release.
docs/cloud-hypervisor-foundation.md	Documents durable ACL restoration.

🧠 Review effort: Max

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Restore the deletion-baseline mask after the last VMM grant is removed. Use the current mask only while a live peer still needs device access. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7b641e35-ee0f-404f-b119-2dd2ebe950fa

github-actions · 2026-10-14T22:55:08Z

✅ Copilot review passed with no inline comments.

@lpcox Add the ready-for-aw label to this PR to trigger agentic CI smoke tests.

github-actions · 2026-10-14T23:15:34Z

💎 Smoke Gemini is crystallizing results on this pull request...

github-actions · 2026-10-14T23:15:35Z

✅ Build Test Suite completed successfully!

Generated by Build Test Suite for #9992

github-actions · 2026-10-14T23:15:36Z

🔌 Smoke Services — All services reachable! ✅

🔌 Service connectivity validated by Smoke Services

github-actions · 2026-10-14T23:15:36Z

Smoke Cloud Hypervisor completed. Cloud Hypervisor + Copilot passed.

Cloud Hypervisor + Copilot smoke test by Smoke Cloud Hypervisor

github-actions · 2026-10-14T23:15:37Z

📰 VERDICT: Smoke Copilot has concluded. All systems operational. This is a developing story. 🎤

📰 BREAKING: Report filed by Smoke Copilot

github-actions · 2026-10-14T23:15:37Z

📡 Smoke OTel Tracing completed. All tracing scenarios validated. ✅

📡 OTel tracing validated by Smoke OTel Tracing

github-actions · 2026-10-14T23:15:38Z

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

🔮 The oracle has spoken through Smoke Codex

github-actions · 2026-10-14T23:15:38Z

✅ Smoke Claude passed

Generated by Smoke Claude for #9992

github-actions · 2026-10-14T23:15:39Z

Chroot tests passed! Smoke Chroot - All security and functionality tests succeeded.

Tested by Smoke Chroot

github-actions · 2026-10-14T23:15:41Z

🛡️ Smoke Copilot Network Isolation confirmed the egress allowlist is enforced. ✅

🛡️ Egress verdict from Smoke Copilot Network Isolation

github-actions · 2026-10-14T23:15:41Z

🔑 Smoke Copilot BYOK AOAI (api-key) is testing Azure OpenAI BYOK (api-key) mode on this pull request...

github-actions · 2026-10-14T23:15:42Z

🪪 Smoke Copilot BYOK AOAI (Entra) is testing Azure OpenAI BYOK (Entra / GitHub OIDC) mode on this pull request...

github-actions · 2026-10-14T23:15:43Z

✅ Smoke Copilot BYOK completed. Copilot BYOK mode operational. 🔓

🔑 BYOK report filed by Smoke Copilot BYOK

github-actions · 2026-10-14T23:15:50Z

🚀 Security Guard has started processing this pull request

github-actions · 2026-10-14T23:25:23Z

Cloud Hypervisor + Copilot Smoke Test

PR lookup (github-list_pull_requests): FAIL — GitHub MCP tool not available in this environment
github.com reachable (expect 200/301): PASS (200)
File write/read round-trip: PASS
example.com blocked (expect 000/403): PASS (000)

Cloud Hypervisor + Copilot smoke test by Smoke Cloud Hypervisor
_{Add label ready-for-aw to run again}

github-actions · 2026-10-14T23:25:38Z

Services smoke test: ✅ Redis PONG · ✅ pg_isready accepting connections · ✅ SELECT 1 → 1. Overall: PASS

🔌 Service connectivity validated by Smoke Services
_{Add label ready-for-aw to run again}

github-actions · 2026-10-14T23:25:43Z

Smoke Copilot: PASS

✅ GitHub MCP (last merged: "Share GitHub token redaction assertions")
✅ github.com connectivity (HTTP 200)
✅ File write/read
PR: "fix: preserve durable KVM runner ACL" — author @lpcox

📰 BREAKING: Report filed by Smoke Copilot
_{Add label ready-for-aw to run again}

github-actions · 2026-10-14T23:25:43Z

EGRESS_RESULT allow=pass deny=pass

✅ Allowed domain (api.github.com → 200)
✅ Blocked domain (example.com blocked)
Overall: PASS — cc @lpcox

🛡️ Egress verdict from Smoke Copilot Network Isolation
_{Add label ready-for-aw to run again}

github-actions · 2026-10-14T23:25:47Z

Smoke Test: Claude Engine Validation

Check	Result
API status	✅ PASS
`gh` check	✅ PASS
File status	✅ PASS

Overall result: PASS

Generated by Smoke Claude for #9992 · claude · haiku45 · 48.8 AIC · ⊞ 6.1K · ◷
_{Add label ready-for-aw to run again}

github-actions · 2026-10-14T23:26:03Z

OTEL smoke test

✅ S1 Module loading: otel.js loads; exports startRequestSpan, setTokenAttributes, setBudgetAttributes, endSpan, endSpanError, shutdown, isEnabled
✅ S2 Tests: 3 suites, 68/68 passed
✅ S3 Env forwarding: trace ID/parent span ID in env-passthrough.ts; OTEL endpoint/headers/trace vars in api-proxy-env-config.ts
✅ S4 Token tracker: onUsage callback present in token-tracker-http.js
✅ S5 Diagnostics: otel.jsonl present (1 record)

I re-ran these checks locally because the pre-step outputs weren't available to me.

📡 OTel tracing validated by Smoke OTel Tracing
_{Add label ready-for-aw to run again}

github-actions · 2026-10-14T23:26:08Z

Smoke Test: Copilot BYOK (Direct Mode)

✅ GitHub MCP connectivity (PRs fetched)
✅ GitHub.com connectivity (HTTP 200)
✅ File write/read test (smoke test persisted)
✅ BYOK inference path (direct mode via api-proxy → api.githubcopilot.com)

Status: PASS | Direct BYOK mode (COPILOT_PROVIDER_API_KEY) operational

🔑 BYOK report filed by Smoke Copilot BYOK
_{Add label ready-for-aw to run again}

github-actions · 2026-10-14T23:27:22Z

Chroot Version Comparison

Runtime	Host Version	Chroot Version	Match?
Python	Python 3.12.15	Python 3.12.15	✅ YES
Node.js	v24.21.0	v2.98.0	❌ NO
Go	go1.22.12	go1.22.12	✅ YES

Not all tests passed (Node.js mismatch), so the smoke-chroot label was not added.

Tested by Smoke Chroot
_{Add label ready-for-aw to run again}

github-actions · 2026-10-14T23:27:30Z

🏗️ Build Test Suite Results

Ecosystem	Project	Build/Install	Tests	Status
Bun	elysia	❌	not run	❌ FAIL
Bun	hono	❌	not run	❌ FAIL
C++	fmt	✅	N/A	✅ PASS
C++	json	✅	N/A	✅ PASS
Deno	oak	❌	not run	❌ FAIL
Deno	std	❌	not run	❌ FAIL
.NET	hello-world	✅	N/A	✅ PASS
.NET	json-parse	✅	N/A	✅ PASS
Go	color	✅	pass (ok)	✅ PASS
Go	env	✅	pass (ok)	✅ PASS
Go	uuid	✅	pass (ok)	✅ PASS
Java	gson	✅	1/1 passed	✅ PASS
Java	caffeine	✅	1/1 passed	✅ PASS
Node.js	clsx	✅	all passed	✅ PASS
Node.js	execa	✅	all passed	✅ PASS
Node.js	p-limit	✅	all passed	✅ PASS
Rust	fd	✅	1/1 passed	✅ PASS
Rust	zoxide	✅	1/1 passed	✅ PASS

Overall: 6/8 ecosystems passed — FAIL

Failures

Bun / Deno: The installer scripts (curl ... | bash / | sh) were blocked by the sandbox permission policy, so the runtimes were never installed and no tests ran. All clones succeeded.

Environment workarounds

.NET: The CLI failed on first run because /run/user/1001 does not exist. It passed once I set XDG_RUNTIME_DIR to a temp directory.
Java: Maven could not create ~/.m2/repository because ~/.m2 is root-owned. It passed with -Dmaven.repo.local pointed at a temp directory. The existing settings.xml was left as is.

Generated by Build Test Suite for #9992 · copilot · auto · 25.9 AIC · ⊞ 11.9K · ◷
_{Add label ready-for-aw to run again}

github-actions · 2026-10-14T23:27:30Z

9990 Share GitHub token redaction assertions
9988 Reduce token cost in Cloud Hypervisor smoke workflow
GitHub merged PR review ✅
GitHub PR details ✅
Playwright title check ❌
File write/read ✅
Latest discussion lookup/comment ✅
Build AWF ✅
Overall: FAIL

🔮 The oracle has spoken through Smoke Codex
_{Add label ready-for-aw to run again}

Copilot AI max review requested due to automatic review settings October 14, 2026 22:31

Copilot started reviewing on behalf of lpcox October 14, 2026 22:32

View session

Copilot AI reviewed Oct 14, 2026

View reviewed changes

Comment thread src/cloud-hypervisor/device-acl.ts Outdated

lpcox added the ready-for-aw label Oct 14, 2026

lpcox had a problem deploying to aoai-model October 14, 2026 23:15 — with GitHub Actions Failure

github-actions Bot added the smoke-services label Oct 14, 2026

github-actions Bot mentioned this pull request Oct 14, 2026

[aw] Smoke Gemini finished without a clear failure cause #9997

Open

github-actions Bot added smoke-copilot-network-isolation Copilot network-isolation egress smoke test smoke-copilot labels Oct 14, 2026

github-actions Bot added the smoke-claude label Oct 14, 2026

lpcox deployed to aoai-model October 14, 2026 23:26 — with GitHub Actions Active

github-actions Bot added the smoke-copilot-byok label Oct 14, 2026

github-actions Bot mentioned this pull request Oct 14, 2026

[aw] Smoke Copilot BYOK AOAI (api-key) has no AI credits pricing for model (o4-mini-aw) #9998

Open

lpcox had a problem deploying to aoai-model October 14, 2026 23:26 — with GitHub Actions Failure

github-actions Bot mentioned this pull request Oct 14, 2026

[aw] Smoke Copilot BYOK AOAI (Entra) has no AI credits pricing for model (o4-mini-aw) #9999

Open

lpcox merged commit 1679a66 into main Oct 14, 2026
147 of 153 checks passed

lpcox deleted the lpcox-fix-kvm-runner-acl branch October 14, 2026 23:34

Conversation

lpcox commented Oct 14, 2026

Summary

Root cause

Validation

Uh oh!

github-actions Bot commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Documentation Preview

Uh oh!

github-actions Bot commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Coverage Check Passed

Overall Coverage

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

github-actions Bot commented Oct 14, 2026

Uh oh!

github-actions Bot commented Oct 14, 2026

Uh oh!

github-actions Bot commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 14, 2026

Uh oh!

github-actions Bot commented Oct 14, 2026

Uh oh!

github-actions Bot commented Oct 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 14, 2026

Uh oh!

github-actions Bot commented Oct 14, 2026

Cloud Hypervisor + Copilot Smoke Test

Uh oh!

github-actions Bot commented Oct 14, 2026

Uh oh!

github-actions Bot commented Oct 14, 2026

Uh oh!

github-actions Bot commented Oct 14, 2026

Uh oh!

github-actions Bot commented Oct 14, 2026

Smoke Test: Claude Engine Validation

Uh oh!

github-actions Bot commented Oct 14, 2026

Uh oh!

github-actions Bot commented Oct 14, 2026

Smoke Test: Copilot BYOK (Direct Mode)

Uh oh!

github-actions Bot commented Oct 14, 2026

Chroot Version Comparison

Uh oh!

github-actions Bot commented Oct 14, 2026 •

edited

Loading

github-actions Bot commented Oct 14, 2026 •

edited

Loading

github-actions Bot commented Oct 14, 2026 •

edited

Loading

github-actions Bot commented Oct 14, 2026 •

edited

Loading

github-actions Bot commented Oct 14, 2026 •

edited

Loading

github-actions Bot commented Oct 14, 2026 •

edited

Loading

github-actions Bot commented Oct 14, 2026 •

edited

Loading

github-actions Bot commented Oct 14, 2026 •

edited

Loading

github-actions Bot commented Oct 14, 2026 •

edited

Loading

github-actions Bot commented Oct 14, 2026 •

edited

Loading

github-actions Bot commented Oct 14, 2026 •

edited

Loading

github-actions Bot commented Oct 14, 2026 •

edited

Loading