Repository navigation
[log] Add debug logging to proxy config resolvers in cmd/proxy.go - #14566
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
The changes are limited to straightforward logging calls with side-effect-free arguments and no identified blocking issues.
0 open findings
What changed in this PR
Adds debug visibility to delegation and enclave proxy configuration resolution using the existing logProxyCmd logger.
Changes:
- Adds six logs covering disabled modes, resolution progress, and success.
- Leaves configuration behavior unchanged and omits envelope, capability key, and policy contents.
| File | Description |
|---|---|
internal/cmd/proxy.go |
Adds diagnostic logging to both proxy configuration resolvers. |
🧠 Review effort: Balanced
Give feedback about Copilot approvals in this survey to enter a drawing for a $150 gift card.
🔒 mcpg Read-Only Stress — defaultSurface coverage: MCP tool calls + proxied CLI (REST) + GraphQL mutations
Overall: INCONCLUSIVE No write leaked in any part. Gaps:
Independent evidence of mcpg's own write-blocking (DIFC/guard layer) remains covered by
|
Adds 6 debug log calls using the existing
logProxyCmdlogger ininternal/cmd/proxy.go:resolveDelegationProxyConfig: disabled path, store loading (path/generation/listen addr), success.resolveEnclaveProxyConfig: disabled path, resolution start (booleans/counts only), success.No secrets are logged (envelope, capability key, and policy contents are omitted) and no log arguments have side effects.
Validation:
go vet ./internal/cmd,go test ./internal/cmd, andgo buildall pass.