Skip to content

Sync from gdc-ui/sdk hash:ddcf67c - #7480

Merged
yenkins-admin merged 2 commits into
masterfrom
sync-from-gdc-ui-41602343657
Nov 3, 2026
Merged

yenkins-admin merged 2 commits into
masterfrom
sync-from-gdc-ui-41602343657

Conversation

@yenkins

@yenkins yenkins commented Nov 3, 2026 •

Copy link
Copy Markdown

Automated sync of gdc-ui → gooddata-ui-sdk

Source hash: ddcf67c

Summary by CodeRabbit

  • New Features

    • Workspace permissions now include document creation. Users with this permission can create Publisher documents and manage documents they created; workspace managers retain broader access.
    • Added reusable AI composing indicators, including waiting, building, and generating states, with an optional “Reply now” action.
    • AI assistant chat now supports typed events for document and dashboard saves.
  • Bug Fixes

    • Delete actions in visualization lists can be activated with Enter or Space, and row actions remain visible after dialogs close.
    • Long words now wrap within dialogs.
    • Dashboard composing overlays and reply controls have been removed.

@yenkins yenkins added the sync PR is created from gdc-ui label Nov 3, 2026

@yenkins-admin yenkins-admin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved by sync workflow

@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Walkthrough

Changes

Release publishing

Layer / File(s) Summary
Package and publish actions
.github/actions/npm/..., .github/actions/rush/...
Adds tarball packing, artifact upload, npm publishing, retries, access policies, and already-published handling.
Trusted publishing workflow wiring
.github/workflows/*release*.yml, .github/workflows/rw-*
Adds trusted-publishing inputs, legacy token fallbacks, version validation, and failure notification coverage.

Workspace document permissions

Layer / File(s) Summary
Permission contracts and backend mapping
libs/api-client-tiger/..., libs/sdk-model/..., libs/sdk-backend-*/...
Adds CREATE_DOCUMENT and canCreateDocument; MANAGE grants the capability.
Permission management UI and validation
libs/sdk-ui-ext/..., libs/sdk-ui/..., libs/sdk-ui-*/...
Adds the granular permission, localization, sanitization behavior, fixtures, and tests.

Typed AI assistant events

Layer / File(s) Summary
Chat and application event contracts
libs/sdk-pluggable-application-model/...
Adds typed chat and application event envelopes, guards, saved-event helpers, and public exports.
Sequenced application event delivery
libs/sdk-ui-gen-ai/..., libs/sdk-ui-pluggable-host/...
Queues application events, forwards typed chat events, and converts recognized events into chat store actions.

Copilot and dashboard UI

Layer / File(s) Summary
Composing components and presentation
libs/sdk-ui-gen-ai/...
Adds controlled and handler-backed composing components, overlay styles, localization, documentation, and tests.
Dashboard composing removal
libs/sdk-ui-dashboard/...
Removes dashboard reasoning-title and reply-flow APIs and retains interaction-lock coverage.

UI polish

Layer / File(s) Summary
Interaction and layout fixes
common/changes/..., libs/sdk-ui-kit/...
Adds keyboard delete-button handling, focus-visible action display, and long-word wrapping.

Estimated code review effort: 5 (Critical) | ~90 minutes

Change: Other

Sequence Diagram(s)

sequenceDiagram
  participant HostUiContainer
  participant PluggableApplicationRenderer
  participant HostChat
  participant GenAIChatDialogConnected
  HostUiContainer->>PluggableApplicationRenderer: receive app event
  PluggableApplicationRenderer->>HostUiContainer: forward IAiAssistantAppEvent
  HostUiContainer->>HostChat: pass sequenced appEvents
  HostChat->>GenAIChatDialogConnected: pass appEvents
  GenAIChatDialogConnected->>GenAIChatDialogConnected: dispatch recognized save actions
Loading

Possibly related PRs

  • gooddata/gooddata-ui-sdk#7469: Updates workspace granular-permission sanitization and retention rules related to the CREATE_DOCUMENT permission.
Merge Risk: Low · up to 45880

The change is mergeable with owner awareness of several bounded compatibility and presentation issues. Existing Copilot subpath consumers need migration, scoped editors can show unrelated progress text, and publish-only reruns after one day require repacking. Addressing these before release would reduce upgrade and recovery friction.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit packs tarballs neat,
Typed events hop from host to seat.
Documents gain a permission bright,
Copilot glows with waiting light.
Keys now guide the delete command,
And long names fit where they should stand.

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

@yenkins-admin
yenkins-admin merged commit 2a4bd55 into master Nov 3, 2026
15 of 16 checks passed
@yenkins-admin
yenkins-admin deleted the sync-from-gdc-ui-41602343657 branch November 3, 2026 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sync PR is created from gdc-ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants