Repository navigation
Fixed Reflex Debugger to support Unity Build Profiles - #156
Open
EduardSmilyi wants to merge 2 commits into
Open
EduardSmilyi wants to merge 2 commits into
EduardSmilyi wants to merge 2 commits into
Conversation
- Introduced `DebuggerState` enum with flags for better state tracking. - Refactored how `REFLEX_DEBUG` is checked using a helper method. - Improved the tooltip with detailed state information. - Added compilation request and warnings for specific scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed Reflex Debugger to support Unity Build Profiles
Description
Motivation and issue: In a Unity project with Build Profiles, we use Scripting Defines with
REFLEX_DEBUGthat extend the Scripting Define Symbols. As a result, the Reflex Debugger (which relies on the Scripting Define Symbols) refuses to show debug information, even thoughREFLEX_DEBUGis enabled and performance is impacted!Fixed Reflex Debugger to display the real state of
REFLEX_DEBUGusing preprocessor checksDebuggerStateenum with flags for better state tracking.REFLEX_DEBUGis checked using a helper method.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Prepared release: https://github.com/EduardSmilyi/Reflex.git?path=/Assets/Reflex/#14.4.0
REFLEX_DEBUGset in Build Profile/Scripting Defines.REFLEX_DEBUGREFLEX_DEBUGto Scripting Define Symbols on the debug button pressREFLEX_DEBUGset in Build Profile/Scripting Defines and Scripting Define SymbolsREFLEX_DEBUGto Scripting Define SymbolsREFLEX_DEBUGis present in the Scripting Define SymbolsREFLEX_DEBUGREFLEX_DEBUGfrom Scripting Define Symbols on the debug button press; it also doesn't allow addingREFLEX_DEBUGafterwardREFLEX_DEBUGset in Build Profile/Player Settings.REFLEX_DEBUGto the Scripting Define Symbols defined in the Build Profile/Player SettingsREFLEX_DEBUGis present in the Build Profile/Player Settings Scripting Define Symbols but not in the global onesREFLEX_DEBUGfrom the Scripting Define Symbols defined in the Build Profile/Player SettingsREFLEX_DEBUGis not present in the Build Profile/Player Settings Scripting Define SymbolsTest Configuration:
Checklist: