Repository navigation
Fix SizeSpecificArrayPool losing expanded buckets - #158
Open
armadavalor wants to merge 1 commit into
Open
armadavalor wants to merge 1 commit into
armadavalor wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SizeSpecificArrayPool.Rent resized a local copy of the bucket with Array.Resize but never stored it back in _buckets[length]. Rentals past the first expansion kept allocating new buckets, and the 9th outstanding rental of the same length threw IndexOutOfRangeException.
This stores the resized bucket back into _buckets[length], and adds an edit mode test that rents more than two expansions' worth of arrays.
Tested: not compiled in Unity and the NUnit tests were not run in the Unity Test Runner. I compiled the pool class alone in a scratch .NET 7 project: before the change the 9th rental throws, after it 17 rentals of the same length return 17 distinct arrays.
Closes #155