Skip to content

pr-review: auto-fix on a reviewed head repairs from our submitted review - #419

Merged
hathach merged 6 commits into
mainfrom
auto-fix-same
Nov 3, 2026
Merged

hathach merged 6 commits into
mainfrom
auto-fix-same

Conversation

@hathach

@hathach hathach commented Nov 3, 2026 •

Copy link
Copy Markdown
Owner

/pr-review N auto-fix on a head we already reviewed (prepare's same) now repairs from our review submitted on that
head, by the human included, instead of needing auto-fix full's whole-head re-review (~$30 on #379).

The recipe ran the repair only once this run's step 5 reported posted, and a same head takes a discussion run
whose answers only go pending, so plain auto-fix never repaired there. The mechanism did not need that rule:
ledger.py show --fixable reads submitted_last(), which accepts our review whoever submitted it, and post.py's
sync records a human's submit. On #379 run 4 handed its review over; once the maintainer submits it, its deferred
answers still blocked the next prepare.

  • prepare.py --auto-fix on same: repair.submittedReview (the review id, or null with repair.submittedWhy);
    exactly one unsent auto answer bundle of that review on the head no longer refuses the run
    (repair.deferredAnswers); every other pending draft, a drafted/uncertain review and runs without --auto-fix
    refuse as before.
  • SKILL.md / chief.md: with submittedReview, steps 3-5 are skipped when the repair can push or answers are deferred
    (a discussion cannot change what is repaired: findings with pushback stay held, and step 6.4 judges that
    pushback); otherwise the discussion runs as before. Step 6 starts from that review; the deferred answers are
    published pending at the end only if the head did not move. The PR review grant names the reused review.
  • full and incremental, ledger.py, post.py and the workflow are unchanged.

Tests: python -X utf8 -m unittest discover -s tests — Ran 4279 tests, OK (skipped=127) at 9153d7e, before a rebase onto #400 (HIL only, no shared file); tests.test_agents + tests.test_pr_review OK again at 403de12.

Copilot AI balanced review requested due to automatic review settings November 3, 2026 10:40
@coderabbitai

coderabbitai Bot commented Nov 3, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3c4a6a43-c9b7-4da9-8912-82aa9e3ee3f9
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@greptile-apps

greptile-apps Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

Allows auto-fix to repair an already-reviewed head from our submitted review, including one the human submitted.

  • Auto-fix repairs an already-reviewed head from its submitted review.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A["prepare --auto-fix"] --> B{"Same reviewed head?"}
  B -->|No| C["Existing review and repair flow"]
  B -->|Yes| D{"Submitted review on this head?"}
  D -->|No| E["Report why reuse is unavailable"]
  D -->|Yes| F["Reuse review; allow its one deferred bundle"]
  F --> G["Read live threads; hold pushback and changed claims"]
  G --> H["Repair eligible findings and recheck"]
  H --> I["Publish deferred answers only if head stayed unchanged"]
Loading

Reviews (1) · Last reviewed commit: "pr-review: the pre-launch report names t..." · Reviewed by Greptile

@hathach
hathach merged commit 129f521 into main Nov 3, 2026
13 checks passed
@hathach
hathach deleted the auto-fix-same branch November 3, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants