Repository navigation
pr-review: auto-fix on a reviewed head repairs from our submitted review - #419
Merged
Merged
Conversation
… head repairs from
…d its fields into repair
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
[Medium impact] The PR appears safe to merge; no actionable issues were found.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/pr-review N auto-fixon a head we already reviewed (prepare'ssame) now repairs from our review submitted on thathead, by the human included, instead of needing
auto-fix full's whole-head re-review (~$30 on #379).The recipe ran the repair only once this run's step 5 reported
posted, and asamehead takes a discussion runwhose answers only go pending, so plain
auto-fixnever repaired there. The mechanism did not need that rule:ledger.py show --fixablereadssubmitted_last(), which accepts our review whoever submitted it, andpost.py'ssync records a human's submit. On #379 run 4 handed its review over; once the maintainer submits it, its deferred
answers still blocked the next prepare.
--auto-fixonsame:repair.submittedReview(the review id, or null withrepair.submittedWhy);exactly one unsent
autoanswer bundle of that review on the head no longer refuses the run(
repair.deferredAnswers); every other pending draft, a drafted/uncertain review and runs without--auto-fixrefuse as before.
submittedReview, steps 3-5 are skipped when the repair can push or answers are deferred(a discussion cannot change what is repaired: findings with pushback stay held, and step 6.4 judges that
pushback); otherwise the discussion runs as before. Step 6 starts from that review; the deferred answers are
published pending at the end only if the head did not move. The PR review grant names the reused review.
fullandincremental,ledger.py,post.pyand the workflow are unchanged.Tests:
python -X utf8 -m unittest discover -s tests— Ran 4279 tests, OK (skipped=127) at 9153d7e, before a rebase onto #400 (HIL only, no shared file);tests.test_agents+tests.test_pr_reviewOK again at 403de12.