Repository navigation
fix: input fields paint the theme input color, readable under win98 - #1072
Open
SOUMITRO-SAHA wants to merge 3 commits into
Open
SOUMITRO-SAHA wants to merge 3 commits into
SOUMITRO-SAHA wants to merge 3 commits into
Conversation
Contributor
Author
|
Demo recording — left: dev build with this PR · right: production app — both on the Win98 layout. What to look for:
2026-11-15_02-24-11.mp4 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #824
Problem
With the Win98 theme, input fields painted
.bg(t.background)+.text_color(t.foreground), and the theme sets both to#000000— typed text was invisible in the command palette (Cmd+Shift+P), the picker (Cmd+P), help, prompt, worktree, machine-add, settings (machine rename, font picker search), feedback and the changes commit-message field.Selected text was unreadable too: the theme's
selectionis opaque#000080(navy) and selected glyphs keep their black ink.Fix
Input fields take the theme's
inputcolor as their background — no hardcoded values, each theme decides:colors.input: #ffffff→ the white Win98 text box with black text#ffffff24dark /#00000026light), so fields read as fields in every themeFields that had no background of their own (settings font-picker search, changes commit message) get
bg(t.input)as well, so they are readable under win98 too.Selection readability (
defaults/themes/win98.json): theme files require opaque#rrggbbfor palette fields but allow#rrggbbaaincolors, and the terminal drops alpha when it reads this token. So acolors.selection: "#00008080"override gives panels a translucent navy band (black selected text reads on the white field) while the terminal keeps its authentic opaque navy selection.Docs:
defaults/AGENTS.mdanddefaults/herdr.d.tsnow describeinputas "text fields, a stronger border".Testing
just test: 148 bun + 490 cargo tests passherdr-app checkpasses for all six changed mods