Repository navigation
サービストークンの自動処理設定に必須項目を指定 - #295
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
service_token_inactivityにenabled = falseしかなく,APIが要求する3項目を満たしていなかった。ignore_changesを削除し,enabled = false,action = "disable",inactivity_threshold_days = 90を明示する。動作確認
mise run fmt,mise run validate:成功。mise run plan:Terraform Cloudで成功。0 to add, 2 to change, 0 to destroy。service_token_inactivityに不足していた2項目を追加し,WARPの認証セッション期間を24時間に設定する。ignore_changesでは不完全な値の送信を防げない。レビュー観点