Repository navigation
Conversation
LSAPI_Write() returns either the full length or -1, but sapi_lsapi_ub_write() kept the result in an int and compared it with the size_t length, so -1 never took the error branch: a failed write was reported as complete and php_handle_aborted_connection() was not called. The short-write branch also returned str_length - ret instead of ret. The stdout fallback loop now counts in size_t and ssize_t as well. Fixes phpGH-23424
iliaal
force-pushed
the
fix/aph-litespeed-write-accounting-opzz-84-work
branch
from
October 4, 2026 19:32
de446fe to
70cd812
Compare
iliaal
changed the title
Owner
Author
|
Submitted upstream as php#24124. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return actual bytes written from LiteSpeed ub_write and handle signed transport failures and partial writes according to SAPI conventions.