Skip to content

chore(agents): replace PR write enforcement with prose guidance - #8013

Merged
jstirnaman merged 1 commit into
masterfrom
chore/prose-collaborative-pr-guidance
Nov 5, 2026
Merged

jstirnaman merged 1 commit into
masterfrom
chore/prose-collaborative-pr-guidance

Conversation

@jstirnaman

Copy link
Copy Markdown
Contributor

What changed

Remove the collaborative PR write guard and its Codex and Claude PreToolUse registrations.
Remove the guard's tests, package command, CI wiring, and reference document.
Keep the collaborative PR skill as prose guidance.
Clarify that reviews and suggestions use the normal tools within the user's requested scope.

Why

The hook blocked an authorized review on PR #7956 because it treated a review POST as a protected branch write.
The guard provided no operation for submitting reviews.
Maintaining interception code for Git and GitHub behavior adds friction beyond the intended collaboration rule.

Impact

Substantive changes to another contributor's branch still require explicit direct-push authorization or a reviewable proposal.
The prose workflow retains contributor forks, preserved authorship, successor PRs, and independent review of the invoker's own PR.
Unrelated hooks and instruction validation, linting, source link checking, and CI routing remain in place.
Existing agent sessions may need to reload repository hook configuration after updating their checkout.

Verification

  • yarn build:agent:instructions and yarn validate:agent-instructions pass.
  • All 13 remaining CI-routing and preview-isolation tests pass.
  • Claude JSON and agent workflow YAML parse; unrelated PreToolUse hooks remain.
  • Local links in the skill pass lychee --offline.
  • Code-comment lint, formatting, and git diff --check pass.
  • Repository search finds no remaining references to the removed guard.
  • The optional skill-creator Python checker could not run because PyYAML is unavailable; repository skill validation passes.
  • GitHub CI remains pending.

Preview pages

Not applicable. No published pages change.

Checklist

  • Signed the InfluxData CLA (if necessary) — not reverified.
  • Rebased/mergeable — based on fetched GitHub master; GitHub mergeability will be checked.
  • Local build passes (npx hugo --quiet) — full site build not run for this agent-tooling removal; focused checks are listed above.

Suggested reviewers (click to expand)

Based on files changed, consider requesting review from:

InfluxDB 3

Content Engineering Product
Core, Enterprise influxdata/monolith-team peterbarnett03, garylfowler
Clustered influxdata/platform-team ritwika314, sanderson
Cloud Dedicated influxdata/cloud-single-tenant ritwika314, sanderson
Cloud Serverless - mavarius, garylfowler
Explorer - mavarius, peterbarnett03

InfluxDB v2 / v1 / Enterprise v1

Content Engineering Product
v2, Cloud (TSM) influxdata/edge sanderson, jstirnaman
v1, Enterprise v1 influxdata/edge sanderson, jstirnaman

Other Products

Content Engineering Product
Telegraf influxdata/telegraf-team sanderson, caterryan
Kapacitor influxdata/bonitoo sanderson, jstirnaman
Chronograf influxdata/bonitoo mavarius, caterryan
Flux - sanderson, jstirnaman

Shared / Cross-Product

Content Reviewers
/content/shared/ influxdata/product-managers
API docs Relevant product team above

What changed: Remove the PR write guard, its Codex and Claude hook entries,
guard-specific tests, package command, CI wiring, and reference document.
Clarify the existing collaborative PR skill's guidance for reviews and comments.

Why: The hook blocked a requested review without providing a way to submit
it. Collaboration guidance should preserve author control without adding code
that intercepts Git and GitHub operations.

Impact: Another author's branch still requires direct-push authorization in
the prose workflow. Reviews use normal tools within the requested scope.
Contributor forks, successor PRs, independent review, unrelated hooks, and
instruction/link/lint checks remain in place.

Verification: Instruction generation and validation pass. All 13 remaining
routing and preview-isolation tests pass. Local skill links, JSON/YAML parsing,
code-comment lint, formatting, and whitespace checks pass. The optional
skill-creator Python checker could not run because PyYAML is unavailable.
@jstirnaman
jstirnaman requested a review from a team as a code owner November 5, 2026 23:30
@jstirnaman
jstirnaman requested review from sanderson and removed request for a team November 5, 2026 23:30
@jstirnaman
jstirnaman merged commit 400cda8 into master Nov 5, 2026
14 checks passed
@jstirnaman
jstirnaman deleted the chore/prose-collaborative-pr-guidance branch November 5, 2026 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant