Repository navigation
chore(agents): add PR review feedback loop to collaborative PR review skill - #8015
Closed
reidkaufmann wants to merge 1 commit into
Closed
reidkaufmann wants to merge 1 commit into
reidkaufmann wants to merge 1 commit into
Conversation
… skill What changed: Add references/review-feedback.md to the collaborative-pr-review skill and link it from SKILL.md. It covers waiting for Copilot re-reviews, replying to review comments with the addressing commit SHA, updating replies after a history rewrite, and fixing links the link checker reports in changed files. Why: Agents waited on Copilot and CI without a polling method, and replies citing squashed commits pointed at SHAs no longer on the branch. Impact: Agent workflow guidance only; no published content changes. Verification: build-agent-instructions and validate-agent-instructions pass; prettier passes.
Contributor
Author
|
This is generic enough it probably doesn't belong here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR doesn't close an issue.
What changed
Adds a review-feedback reference to the collaborative PR review skill, linked from
SKILL.md.It covers waiting for Copilot to re-review after a push, replying to each review comment with the commit that addresses it, and updating those replies after a squash or rebase.
It also says to fix broken links the link checker reports in changed files, even when the PR didn't add them.
Why
On #7981, Copilot re-reviewed after each push, and two replies cited commits that a later squash removed from the branch.
The link checker also reported anchors that were broken before the PR.
Impact
Agent guidance only; no published pages change.
Verification
yarn build:agent:instructionsandyarn validate:agent-instructionspass. The new content is inreferences/becauseSKILL.mdhas a 160-line limit.Preview pages
None. The change is limited to
.agents/.Checklist
npx hugo --quiet) — not run; no content or layout changesSuggested reviewers (click to expand)
Based on files changed, consider requesting review from:
InfluxDB 3
InfluxDB v2 / v1 / Enterprise v1
Other Products
Shared / Cross-Product
/content/shared/