Repository navigation
crypto: Refactor RIPEMD-160 functions for inlining - #1800
Merged
Merged
Conversation
Contributor
Merging this PR will improve performance by 94.81%
Performance Changes
Tip Curious why performance improved? Comment Comparing 
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1800 +/- ##
==========================================
- Coverage 98.24% 98.24% -0.01%
==========================================
Files 186 186
Lines 17176 17175 -1
Branches 3921 3922 +1
==========================================
- Hits 16874 16873 -1
Misses 233 233
Partials 69 69
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Force inlining of the helper functions in RIPEMD-160 implementation. The implementation is constructed around inline steps functions, make sure these are always inlined. This actually shortens the code. Additionally, GCC was not able to inline boolean functions behind array of function pointers. Now function specialization is used. Co-authored-by: Paweł Bylica <pawel.bylica@erigon.tech>
chfast
force-pushed
the
crypto/ripemd160-inline
branch
from
November 1, 2026 20:32
9b4f0ff to
10a3255
Compare
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the RIPEMD-160 helper-inlining refactor.
No open issues 🎉
What changed in this PR
Refactors RIPEMD-160 helpers to improve compiler inlining, addressing GCC’s difficulty inlining calls through function-pointer arrays while preserving the hash calculations.
Changes:
- Replaces the Boolean function-pointer array with round-indexed template specializations.
- Adds
always_inlineattributes to Boolean helpers and step functions.
| File | Description |
|---|---|
lib/evmone_precompiles/ripemd160.cpp |
Uses specialized Boolean helpers and forces helper inlining in RIPEMD-160 steps. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Force inlining of the helper functions in RIPEMD-160 implementation. The implementation is constructed around inline steps functions, make sure these are always inlined. This actually shortens the code. Additionally, GCC was not able to inline boolean functions behind array of function pointers. Now function specialization is used.
Upstreamed from erigontech@56dd838.
Co-authored-by: Paweł Bylica pawel.bylica@erigon.tech
Instructions per hash of 1024 bytes (x86-64-v2,
-O3):