Skip to content

Adding calendar page - #165

Open
bsipocz wants to merge 9 commits into
ivoa:mainfrom
bsipocz:calendar
Open

bsipocz wants to merge 9 commits into
ivoa:mainfrom
bsipocz:calendar

Conversation

@bsipocz

@bsipocz bsipocz commented Nov 3, 2026 •

Copy link
Copy Markdown

I'm opening this as draft PR so I can show @stefanv what I have and ask for ideas why I don't yet have the calendars rendered into the output page.

Note, I needed to hack around a lot to make the build work locally, added those as TMP commits to be cleaned up. Current rendered version screenshot.

Screenshot 2026-11-03 at 09 21 30

@bsipocz
bsipocz marked this pull request as draft November 3, 2026 01:22
@bsipocz

bsipocz commented Nov 3, 2026

Copy link
Copy Markdown
Author

@molinaro-m - could you please add me to the ivoa org, so I can open PRs with CI running without needed to wait for approval? thx

@bsipocz

bsipocz commented Nov 3, 2026

Copy link
Copy Markdown
Author

For the sake of easier review (so I don't need to wait for approval for CI for each and every commit) I pushed the output of the calendar page, too.

@bsipocz

bsipocz commented Nov 3, 2026

Copy link
Copy Markdown
Author

This is ready to go now. The only remaining thing is to add a link to the calendar page somewhere in the navbar or footer or somewhere, but I would prefer to do that in a follow up and just merge whatever we have now.

@bsipocz
bsipocz marked this pull request as ready for review November 3, 2026 03:32
@bsipocz

bsipocz commented Nov 3, 2026

Copy link
Copy Markdown
Author

Here is the view I get in the local build:

Screenshot 2026-11-03 at 11 33 04

@bsipocz

bsipocz commented Nov 3, 2026

Copy link
Copy Markdown
Author

And a huge shout out to Stefan for his help and collaboration here!

@bsipocz

bsipocz commented Nov 3, 2026

Copy link
Copy Markdown
Author

@JeremyMcCormick - could you please approve the build to run? The only controversal thing here is that I updated the pinned hugo version, too, but locally I see no problems (besides #163 of course, I couldn't make the existing makefile work for me locally but had to hack it around a bit)

@bsipocz

bsipocz commented Nov 3, 2026

Copy link
Copy Markdown
Author

(and once we merge this I'll have another round of tests that the generated files indeed work as expected for e.g. google calendar, but I'm certain they'll be fine as we use this same system for scientific python)

@molinaro-m

Copy link
Copy Markdown
Member

I am not sure @JeremyMcCormick is following this repo anymore.
@szautkin , @gmantele could you have a look at it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants